Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give proper error when doing sizeof uninstantiated generic type #6418

Merged
merged 3 commits into from Jul 21, 2018
Merged

Give proper error when doing sizeof uninstantiated generic type #6418

merged 3 commits into from Jul 21, 2018

Conversation

asterite
Copy link
Member

Fixes #6415

@straight-shoota
Copy link
Member

Just to make sure, you should probably add a spec for instantiated generic types.

@asterite
Copy link
Member Author

@straight-shoota What about union types? Class types? Pointer types? Aliases? There are so many combinations you could test, I don't think it belongs in this PR, which is about fixing a bug.

@RX14 RX14 added this to the Next milestone Jul 21, 2018
@RX14 RX14 merged commit 753325a into crystal-lang:master Jul 21, 2018
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asterite @straight-shoota @RX14