gitlab: fix module and corresponding test #43844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test gitlab |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.gitlab Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.gitlab Partial log (click to expand)
|
binarin
force-pushed
the
gitlab-fresh-installation-fixes
branch
from
8efbaa4
to
3c49ef6
Compare
|
@GrahamcOfBorg test gitlab |
|
@GrahamcOfBorg test gitlab Currently only trusted users can run builds through ofborg, see https://github.com/NixOS/ofborg#trusted-users-vs-known-users |
|
Failure on x86_64-linux (full log) Attempted: tests.gitlab Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: tests.gitlab Partial log (click to expand)
|
|
The test fails because systemd for some reason decides to enforce start timeout, despite it being explicitly set to So what to do now? Disable the test back again? |
|
@binarin that's not systemd , but a hard-coded timeout in https://github.com/NixOS/nixpkgs/blob/master/nixos/lib/test-driver/Machine.pm#L231 |
|
I think we had problems with this test inside a VM because the p9 filesystem used to passthrough the nix store is not fast enough to load all ruby gems from gitlab in time. |
|
@flokli systemd is also responsible, by killing a service few times and slowing everything even more: |
|
That's really weird, |
binarin
force-pushed
the
gitlab-fresh-installation-fixes
branch
2 times, most recently
from
b96767b
to
0335a12
Compare
|
Searching around the internet showed that |
|
@GrahamcOfBorg test gitlab |
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
|
@binarin can you rebase? |
|
@flokli I've tried to do so half an hour ago, but |
This fixes some things I've encountered while trying to use this module: - uploads symlink from store was broken, causing migrations on fresh installation to fail - Get `lib` folder from configured package, not from a global `gitlab` one - Increase memory limit, so the test will be able to pass
Looks like systemd is having some problem with respecting `infinity`
binarin
force-pushed
the
gitlab-fresh-installation-fixes
branch
from
0335a12
to
0f30ee6
Compare
|
@flokli Just rebased this. On my machine the test works again, took around 1000 seconds to succeed. |
|
@GrahamcOfBorg test gitlab |
|
Uff, 16 minutes is quite a long time. Do you see what's taking so long here? |
|
@flokli it is loading ruby files from p9 file system which is super slow. |
|
The longest part of a test is applying all the migrations. I don't think that applying them on bare-metal was much faster. |
|
Failure on x86_64-linux (full log) Attempted: tests.gitlab Partial log (click to expand)
|
Because it takes at least 10 minutes even on a good bare-metal server.
|
OK, I've found why systemd was killing a unit while despite of I've pushed a change increasing this to 30 minutes, let's try again - maybe it'll be able to finish when not experiencing random kills. |
|
Failure on aarch64-linux (full log) Attempted: tests.gitlab Partial log (click to expand)
|
|
@binarin Thanks for your work so far! I gave this a try, using While applying migrations, That's might be related to parts of Afterwards, it seems to recover, but has a problem with the following task:
I did check, On initial vm boot, I'm not exactly sure about whether we should do parts of the service-specific state directory structure setups on each unit that uses it, or have some |
|
@binarin ping ;-) |
|
@flokli I hope I'll be able to get back to this issue within a few weeks. |
|
superseded by #49658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes some things I've encountered while trying to use this module:
installation to fail
libfolder from configured package, not from a globalgitlabone
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)