fix: atom crash on Glib-GIO-ERROR #44067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e atom to crash due to missing GIO files
Mic92
reviewed
Aug 1, 2018
| @@ -24,7 +24,9 @@ let | |||
| sed -i "s/${pname})/.${pname}-wrapped)/" $out/bin/${pname} | |||
| # sed -i "s/'${pname}'/'.${pname}-wrapped'/" $out/bin/${pname} | |||
| wrapProgram $out/bin/${pname} \ | |||
| --prefix "PATH" : "${gvfs}/bin" | |||
| --prefix "PATH" : "${gvfs}/bin" \ | |||
| --suffix "XDG_DATA_DIRS" : "${gtk3}/share/gsettings-schemas/${gtk3.name}/"; | |||
There was a problem hiding this comment.
@jtojnar I guess wrapGAppsHook is more robust here?
There was a problem hiding this comment.
Yep, now that electron uses gtk3, wrapGAppsHook would work. Although, the PATH would need to be added to gappsWrapperArgs.
There was a problem hiding this comment.
alright, will use wrapGAppsHook then
about gappsWrapperArgs: what is supposed to be put in there? like --prefix "PATH" : "${gvfs}/bin"?
There was a problem hiding this comment.
it takes the same arguments as wrapProgram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
in the recent unstable releases of nixos atom used to crash when opening file open/save dialogs.
This might be related to a similar issue happening with sakura (#21698, #21700) which is also the inspiration for this fix
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)