Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.thumbor: 6.5.1 -> 6.5.2 #45062

Merged
merged 1 commit into from Aug 15, 2018
Merged

pythonPackages.thumbor: 6.5.1 -> 6.5.2 #45062

merged 1 commit into from Aug 15, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 15, 2018 •
edited

Motivation for this change

6.5.2 allows Pillow==5.2.0 (see https://github.com/thumbor/thumbor/releases/tag/6.5.2).

See https://hydra.nixos.org/build/79403232 for further reference.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner August 15, 2018 11:56
@timokau
Copy link
Member

timokau commented Aug 15, 2018

@GrahamcOfBorg build python2Packages.tumbor python3Packages.tumbor

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2Packages.tumbor, python3Packages.tumbor

Partial log (click to expand)

Cannot nix-instantiate `python2Packages.tumbor' because:
error: attribute 'tumbor' in selection path 'python2Packages.tumbor' not found

Cannot nix-instantiate `python3Packages.tumbor' because:
error: attribute 'tumbor' in selection path 'python3Packages.tumbor' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python2Packages.tumbor, python3Packages.tumbor

Partial log (click to expand)

Cannot nix-instantiate `python2Packages.tumbor' because:
error: attribute 'tumbor' in selection path 'python2Packages.tumbor' not found

Cannot nix-instantiate `python3Packages.tumbor' because:
error: attribute 'tumbor' in selection path 'python3Packages.tumbor' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: python2Packages.tumbor, python3Packages.tumbor

Partial log (click to expand)

Cannot nix-instantiate `python2Packages.tumbor' because:
error: attribute 'tumbor' in selection path 'python2Packages.tumbor' not found

Cannot nix-instantiate `python3Packages.tumbor' because:
error: attribute 'tumbor' in selection path 'python3Packages.tumbor' not found

@timokau
Copy link
Member

timokau commented Aug 15, 2018

@GrahamcOfBorg build python2Packages.thumbor python3Packages.thumbor

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.thumbor

The following builds were skipped because they don't evaluate on x86_64-darwin: python3Packages.thumbor

Partial log (click to expand)

Successfully installed thumbor-6.5.2
/private/tmp/nix-build-python2.7-thumbor-6.5.2.drv-0/thumbor-6.5.2
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2/lib  /nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2/bin
patching script interpreter paths in /nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2
wrapping `/nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2/bin/thumbor-url'...
wrapping `/nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2/bin/thumbor-config'...
wrapping `/nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2/bin/thumbor'...
/nix/store/aykmh1qapgpsq42ipqrb62f6xip86lvz-python2.7-thumbor-6.5.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.thumbor

The following builds were skipped because they don't evaluate on x86_64-linux: python3Packages.thumbor

Partial log (click to expand)

shrinking /nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/lib/python2.7/site-packages/thumbor/ext/filters/_contrast.so
shrinking /nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/lib/python2.7/site-packages/thumbor/ext/filters/_convolution.so
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/lib  /nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/bin
patching script interpreter paths in /nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2
checking for references to /build in /nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2...
wrapping `/nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/bin/thumbor'...
wrapping `/nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/bin/thumbor-config'...
wrapping `/nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2/bin/thumbor-url'...
/nix/store/nnc78wir57gg239nmyd5n3gsc0xfhm8w-python2.7-thumbor-6.5.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.thumbor

The following builds were skipped because they don't evaluate on aarch64-linux: python3Packages.thumbor

Partial log (click to expand)

shrinking /nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/lib/python2.7/site-packages/thumbor/ext/filters/_saturation.so
shrinking /nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/lib/python2.7/site-packages/thumbor/ext/filters/_sharpen.so
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/lib  /nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/bin
patching script interpreter paths in /nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2
checking for references to /build in /nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2...
wrapping `/nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/bin/thumbor-config'...
wrapping `/nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/bin/thumbor-url'...
wrapping `/nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2/bin/thumbor'...
/nix/store/zyh8nlnh9mi3q97qhk5afrdbvqyb276p-python2.7-thumbor-6.5.2

@timokau
Copy link
Member

timokau commented Aug 15, 2018

Thanks!

@timokau timokau merged commit 86dc867 into NixOS:master Aug 15, 2018
@Ma27 Ma27 deleted the fix-python-thumbor branch August 15, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @timokau @GrahamcOfBorg