Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptask: remove usage of nonexistent function is_error #45051

Merged
merged 2 commits into from
Aug 15, 2018
Merged

ptask: remove usage of nonexistent function is_error #45051

merged 2 commits into from
Aug 15, 2018
+15 −1

Conversation

typetetris
Copy link
Contributor

see json-c/json-c#304

Motivation for this change

Fix #45049

Things done

upstreaming the patch by mailing it to jeanfi@gmail.com

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@srhb
Copy link
Contributor

srhb commented Aug 15, 2018

Retriggering eval due to master failure
@GrahamcOfBorg eval

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 15, 2018
@xeji
Copy link
Contributor

xeji commented Aug 15, 2018

@GrahamcOfBorg build ptask

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ptask

Partial log (click to expand)

clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [Makefile:471: ptask] Error 1
make[3]: Leaving directory '/private/tmp/nix-build-ptask-1.0.0.drv-0/ptask-1.0.0/src'
make[2]: *** [Makefile:557: all-recursive] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-ptask-1.0.0.drv-0/ptask-1.0.0/src'
make[1]: *** [Makefile:485: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-ptask-1.0.0.drv-0/ptask-1.0.0'
make: *** [Makefile:384: all] Error 2
builder for '/nix/store/0bvfyr9dh1bch82vx2bg2965nyi7x1j4-ptask-1.0.0.drv' failed with exit code 2
error: build of '/nix/store/0bvfyr9dh1bch82vx2bg2965nyi7x1j4-ptask-1.0.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ptask

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0
shrinking /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0/bin/.ptask-wrapped
gzipping man pages under /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0/bin
patching script interpreter paths in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0
checking for references to /build in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0...
/nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ptask

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0
shrinking /nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0/bin/.ptask-wrapped
gzipping man pages under /nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0/bin
patching script interpreter paths in /nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0
checking for references to /build in /nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0...
/nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0

@xeji
Copy link
Contributor

xeji commented Aug 15, 2018

darwin failure looks unrelated, and I'm not sure this package is supported on MacOS. ofborg just tries it because meta.platforms is missing. It was never built on hydra.

@typetetris while you're at it, could you add meta.platforms = platforms.linux ?

@typetetris
Copy link
Contributor Author

Maybe we could just remove the --as-needed flag to the call to clang on darwin? Maybe it works. But I don't have an mac to test it.

@xeji
Copy link
Contributor

xeji commented Aug 15, 2018

You'd have to patch the source. I think it's better if someone familiar with Mac tries that if they ever need this package.

@typetetris
ptask: prevent building on darwin as this fails as of now

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ff9a38e
@typetetris
Copy link
Contributor Author

As those are two separat topics, I made a second commit.

@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Aug 15, 2018
@xeji
Copy link
Contributor

xeji commented Aug 15, 2018

@GrahamcOfBorg build ptask

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ptask

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ptask

Partial log (click to expand)

/nix/store/5dv7ffjlzbm764hi2ac48m9m0jhjsswb-ptask-1.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ptask

Partial log (click to expand)

make[1]: Leaving directory '/build/ptask-1.0.0'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0
shrinking /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0/bin/.ptask-wrapped
gzipping man pages under /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0/bin
patching script interpreter paths in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0
checking for references to /build in /nix/store/5nmng16ymjsbl1kylmqizdp05cfcvrwl-ptask-1.0.0...

@xeji xeji merged commit 8238101 into NixOS:master Aug 15, 2018
@typetetris typetetris deleted the 45049 branch August 15, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@typetetris @srhb @xeji @GrahamcOfBorg