Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fastcache: init at 1.0.2 #45048

Merged
merged 1 commit into from Aug 15, 2018
Merged

pythonPackages.fastcache: init at 1.0.2 #45048

merged 1 commit into from Aug 15, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Aug 15, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner August 15, 2018 04:23
@bhipple
Copy link
Contributor Author

bhipple commented Aug 15, 2018

@GrahamcOfBorg build python2Packages.fastcache python3Packages.fastcache

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.fastcache, python3Packages.fastcache

Partial log (click to expand)

test_lru_with_maxsize_none (fastcache.tests.test_functools.TestLRU) ... ok
test_lru_with_types (fastcache.tests.test_functools.TestLRU) ... ok
test_need_for_rlock (fastcache.tests.test_functools.TestLRU) ... ok

----------------------------------------------------------------------
Ran 9 tests in 6.710s

OK
/nix/store/jln6lcajvqn0s2ksdwjsg491y0z1mblh-python2.7-fastcache-1.0.2
/nix/store/7b7zbc3yxxkmrpdaxnky4zbays2cx3pi-python3.6-fastcache-1.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.fastcache, python3Packages.fastcache

Partial log (click to expand)

test_lru_with_maxsize_none (fastcache.tests.test_functools.TestLRU) ... ok
test_lru_with_types (fastcache.tests.test_functools.TestLRU) ... ok
test_need_for_rlock (fastcache.tests.test_functools.TestLRU) ... ok

----------------------------------------------------------------------
Ran 9 tests in 48.242s

OK
/nix/store/j9zm00dka6x858bxdksqz1j56k5klvka-python2.7-fastcache-1.0.2
/nix/store/gb314saypk40708d9cmpsngd8j7az83a-python3.6-fastcache-1.0.2

@srhb
Copy link
Contributor

srhb commented Aug 15, 2018

Retriggering eval due to master failure
@GrahamcOfBorg eval

@xeji xeji merged commit 16d4753 into NixOS:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @GrahamcOfBorg @srhb @xeji