Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carnix overrides: add gmp to rink-rs buildInputs & correct crateBin #45050

Merged
merged 1 commit into from Aug 15, 2018
Merged

carnix overrides: add gmp to rink-rs buildInputs & correct crateBin #45050

merged 1 commit into from Aug 15, 2018

Conversation

sjmackenzie
Copy link
Contributor

Motivation for this change

Carnix's defaultCratesOverrides doesn't have rink-rs correct name nor the gmp dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Aug 15, 2018

Retriggering eval due to master failure
@GrahamcOfBorg eval

@sjmackenzie
Copy link
Contributor Author

@srhb the microwave pings - rink-rs deps are ready.

@srhb srhb merged commit cc288ee into NixOS:master Aug 15, 2018
@sjmackenzie sjmackenzie deleted the rink-rs branch August 15, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjmackenzie @srhb @GrahamcOfBorg