Rygel #45045

jtojnar · 2018-08-14T23:14:41Z

Motivation for this change

UPnP server for GNOME, suggested by #247

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

worldofpeace · 2018-08-14T23:23:05Z

pkgs/desktops/gnome-3/core/rygel/default.nix

+    };
+  };
+
+  postFixup = ''


This is empty.

worldofpeace · 2018-08-15T00:06:55Z

pkgs/development/libraries/gupnp-av/default.nix

    homepage = http://gupnp.org/;
    description = "A collection of helpers for building AV (audio/video) applications using GUPnP";
-    license = stdenv.lib.licenses.gpl2;
-    platforms = stdenv.lib.platforms.linux;
+    license = licenses.gpl2;


I think it's licenses.gpl2Plus

worldofpeace · 2018-08-15T00:17:25Z

pkgs/development/libraries/gupnp-dlna/default.nix

+  postPatch = ''
+    chmod +x tests/test-discoverer.sh.in
+    patchShebangs tests/test-discoverer.sh.in
+  '';

  meta = {
    homepage = https://wiki.gnome.org/Projects/GUPnP/;


Same here for the license I think.

srhb · 2018-08-15T08:03:59Z

Retriggering eval due to master failure
@GrahamcOfBorg eval

jtojnar · 2018-08-15T10:15:32Z

pkgs/development/libraries/gupnp/default.nix

  };

-  nativeBuildInputs = [ pkgconfig ];
+  patches = [
+    ./fix-requires.patch


https://bugzilla.gnome.org/show_bug.cgi?id=685477 suggests this might actually be a bug in gupnp-igd and other packages that fail to build without this.

jtojnar · 2018-08-15T14:08:36Z

Added wrapGAppsHook and it now seems to work, but still need to figure out correct firewall settings:

https://bugzilla.redhat.com/show_bug.cgi?id=626188

worldofpeace · 2018-08-15T15:46:04Z

pkgs/desktops/gnome-3/core/rygel/default.nix

@@ -0,0 +1,49 @@
+{ stdenv, fetchurl, pkgconfig, vala, gettext, libxml2, gobjectIntrospection, gtk-doc, wrapGAppsHook, glib, gssdp, gupnp, gupnp-av, gupnp-dlna, gst_all_1, libgee, libsoup, gtk3, libmediaart, sqlite, systemd, tracker, shared-mime-info, gnome3 }:


@jtojnar Maybe a line break?

worldofpeace · 2018-08-22T09:53:54Z

Huh, I guess elementary needs this too https://github.com/elementary/switchboard-plug-sharing/tree/master/src/Backend

jtojnar · 2018-08-26T11:08:24Z

I am trying

{
  networking.firewall.allowedUDPPorts = [ 1900 ];
  networking.firewall.extraPackages = [ pkgs.conntrack_tools ];
  networking.firewall.autoLoadConntrackHelpers = true;
  networking.firewall.extraCommands = ''
    nfct add helper ssdp inet udp
    iptables --verbose -I OUTPUT -t raw -p udp --dport 1900 -j CT --helper ssdp
  '';
}

following http://conntrack-tools.netfilter.org/manual.html#helpers but it is failing since nfct does not like it:

$ sudo nfct add helper ssdp inet udp
nfct v1.4.5: netlink error: Invalid argument

worldofpeace · 2018-08-26T15:18:33Z

following http://conntrack-tools.netfilter.org/manual.html#helpers but it is failing since nfct does not like it:

$ sudo nfct add helper ssdp inet udp
nfct v1.4.5: netlink error: Invalid argument

Hmm that doesn't fail in ubuntu bionic with nfct v1.4.4

GrahamcOfBorg · 2018-09-08T05:15:39Z

Success on x86_64-linux (full log)

Attempted: gnome3.rygel, gssdp, gupnp, gupnp-av, gupnp-dlna, gupnp-igd

Partial log (click to expand)

checking for references to /build in /nix/store/araxann0vdq7y8y54g3172rsp81mhq0h-rygel-0.36.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/38ac6jwq2lwq4rwa62hlxz35514rxllk-rygel-0.36.2-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/38ac6jwq2lwq4rwa62hlxz35514rxllk-rygel-0.36.2-dev/lib
patching script interpreter paths in /nix/store/38ac6jwq2lwq4rwa62hlxz35514rxllk-rygel-0.36.2-dev
checking for references to /build in /nix/store/38ac6jwq2lwq4rwa62hlxz35514rxllk-rygel-0.36.2-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/igws7sw33s2pv187pfzbl1ahv5z9dmbw-rygel-0.36.2-devdoc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/igws7sw33s2pv187pfzbl1ahv5z9dmbw-rygel-0.36.2-devdoc
checking for references to /build in /nix/store/igws7sw33s2pv187pfzbl1ahv5z9dmbw-rygel-0.36.2-devdoc...

GrahamcOfBorg · 2018-09-08T05:34:51Z

Success on aarch64-linux (full log)

Attempted: gnome3.rygel, gssdp, gupnp, gupnp-av, gupnp-dlna, gupnp-igd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/jcz3yraq22d77x7j736blnhq7bwxck47-rygel-0.36.2-devdoc
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jcz3yraq22d77x7j736blnhq7bwxck47-rygel-0.36.2-devdoc
checking for references to /build in /nix/store/jcz3yraq22d77x7j736blnhq7bwxck47-rygel-0.36.2-devdoc...
/nix/store/f5ivnwbn18rr2l2i3hlzg3dxcbd8h3gv-rygel-0.36.2
/nix/store/gr9y3v9ycwahjxxwnyliakf62xv69zyj-gssdp-1.0.2
/nix/store/9p18p9jc3slivlrpx7hz54kdb81ywzk7-gupnp-1.0.3
/nix/store/qk5lqnhn5aaq9lalxglav5x1kbkx39z2-gupnp-av-0.12.10
/nix/store/1v1wjk5yyy85pb592cj9fpql9px4is0c-gupnp-dlna-0.10.5
/nix/store/mb51ican8agwr09zd4rw2nldzgv6zr8p-gupnp-igd-0.2.5

GrahamcOfBorg · 2018-09-08T07:38:46Z

Failure on x86_64-darwin (full log)

Attempted: gssdp

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.rygel, gupnp, gupnp-av, gupnp-dlna, gupnp-igd

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:758: test-suite.log] Error 1
make[3]: Leaving directory '/private/tmp/nix-build-gssdp-1.0.2.drv-0/gssdp-1.0.2/tests'
make[2]: *** [Makefile:866: check-TESTS] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-gssdp-1.0.2.drv-0/gssdp-1.0.2/tests'
make[1]: *** [Makefile:944: check-am] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-gssdp-1.0.2.drv-0/gssdp-1.0.2/tests'
make: *** [Makefile:514: check-recursive] Error 1
builder for '/nix/store/8pm7myi76vm0c1rgg0kqkzqnvsx2m471-gssdp-1.0.2.drv' failed with exit code 2
error: build of '/nix/store/8pm7myi76vm0c1rgg0kqkzqnvsx2m471-gssdp-1.0.2.drv' failed

nixos-discourse · 2022-02-02T17:17:27Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/firewall-rules-with-rygel-gnome-sharing/17471/1

jtojnar added the 2.status: work-in-progress label Aug 14, 2018

GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 14, 2018

worldofpeace reviewed Aug 14, 2018

View reviewed changes

pkgs/desktops/gnome-3/core/rygel/default.nix Outdated

};

};

postFixup = ''

Copy link

Contributor

worldofpeace Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is empty.

jtojnar force-pushed the rygel branch from 1525e5b to 93e55e5 Compare August 14, 2018 23:39

worldofpeace reviewed Aug 15, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Aug 15, 2018

jtojnar force-pushed the rygel branch from 93e55e5 to 0bf92a6 Compare August 15, 2018 08:49

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) labels Aug 15, 2018

jtojnar commented Aug 15, 2018

View reviewed changes

jtojnar force-pushed the rygel branch from 7ca05f6 to 22ce9c0 Compare August 15, 2018 14:07

worldofpeace reviewed Aug 15, 2018

View reviewed changes

jtojnar added 6 commits September 8, 2018 03:09

gssdp: enable docs, tests, gir and split outputs

f0f8229

gupnp: enable docs, gir and split outputs

1aaea38

gupnp-dlna: enable docs, tests and split outputs

5bee539

gupnp: 1.0.2 → 1.0.3

0f063f9

gupnp-av: enable docs, gir, tests and split outputs

05506a2

gupnp-igd: 0.2.4 → 0.2.5

b18461b

jtojnar force-pushed the rygel branch from 22ce9c0 to 2de8295 Compare September 8, 2018 03:48

jtojnar removed the 2.status: work-in-progress label Sep 8, 2018

jtojnar added 2 commits September 8, 2018 06:57

gnome3.rygel: init at 0.36.2

feb18af

nixos/rygel: init

60ae12f

jtojnar force-pushed the rygel branch from 2de8295 to 60ae12f Compare September 8, 2018 04:57

jtojnar merged commit 667e54b into NixOS:master Sep 8, 2018

jtojnar deleted the rygel branch September 8, 2018 05:22

ThibaultLemaire mentioned this pull request Sep 12, 2020

RetroShare appimage fails with appimage-run: libtasn1.so.6: cannot open shared object file #46447

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rygel #45045

Rygel #45045

jtojnar commented Aug 14, 2018 •

edited

worldofpeace Aug 14, 2018

worldofpeace Aug 15, 2018

worldofpeace Aug 15, 2018

srhb commented Aug 15, 2018

jtojnar Aug 15, 2018

jtojnar commented Aug 15, 2018

worldofpeace Aug 15, 2018

worldofpeace commented Aug 22, 2018

jtojnar commented Aug 26, 2018 •

edited

worldofpeace commented Aug 26, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

nixos-discourse commented Feb 2, 2022

		@@ -0,0 +1,49 @@
		{ stdenv, fetchurl, pkgconfig, vala, gettext, libxml2, gobjectIntrospection, gtk-doc, wrapGAppsHook, glib, gssdp, gupnp, gupnp-av, gupnp-dlna, gst_all_1, libgee, libsoup, gtk3, libmediaart, sqlite, systemd, tracker, shared-mime-info, gnome3 }:

Rygel #45045

Rygel #45045

Conversation

jtojnar commented Aug 14, 2018 • edited

Motivation for this change

Things done

worldofpeace Aug 14, 2018

Choose a reason for hiding this comment

worldofpeace Aug 15, 2018

Choose a reason for hiding this comment

worldofpeace Aug 15, 2018

Choose a reason for hiding this comment

srhb commented Aug 15, 2018

jtojnar Aug 15, 2018

Choose a reason for hiding this comment

jtojnar commented Aug 15, 2018

worldofpeace Aug 15, 2018

Choose a reason for hiding this comment

worldofpeace commented Aug 22, 2018

jtojnar commented Aug 26, 2018 • edited

worldofpeace commented Aug 26, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

GrahamcOfBorg commented Sep 8, 2018

nixos-discourse commented Feb 2, 2022

jtojnar commented Aug 14, 2018 •

edited

jtojnar commented Aug 26, 2018 •

edited