Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.orderedset: Fix maintainers list #45054

Closed
wants to merge 1 commit into from
Closed

pythonPackages.orderedset: Fix maintainers list #45054

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 15, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from FRidh as a code owner August 15, 2018 07:47
@xeji
Copy link
Contributor

xeji commented Aug 15, 2018

just fixed it in 6e3d0ef

@xeji xeji closed this Aug 15, 2018
@srhb
Copy link
Contributor Author

srhb commented Aug 15, 2018

Tsk, I was first! ;)

@xeji
Copy link
Contributor

xeji commented Aug 15, 2018

sorry I missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @xeji @GrahamcOfBorg