eclib: 20180710 -> 20180815 #45067
Merged
eclib: 20180710 -> 20180815 #45067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-darwin (full log) Attempted: eclib Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: eclib Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: eclib Partial log (click to expand)
|
infinisil
requested changes
Aug 15, 2018
| @@ -27,14 +27,6 @@ stdenv.mkDerivation rec { | |||
| rev = "v${version}"; | |||
| sha256 = "1kmwpw971sipb4499c9b35q5pz6sms5qndqrvq7396d8hhwjg1i2"; | |||
There was a problem hiding this comment.
You need to update the hash as well
There was a problem hiding this comment.
Wow, good thing I did a PR instead of directly pushing. We really should somehow incorporate the arguments in the hash so that just changing the version fails somehow. Thanks for catching that!
timokau
force-pushed
the
eclib-20180815
branch
from
bceb201
to
8c3db41
Compare
|
@GrahamcOfBorg build eclib |
|
Success on x86_64-linux (full log) Attempted: eclib Partial log (click to expand)
|
infinisil
approved these changes
Aug 15, 2018
|
Success on x86_64-linux (full log) Attempted: eclib Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: eclib Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: eclib Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: eclib Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: eclib Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Small update to incorporate a patch.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)