Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.mattermost-api: skip check #45053

Merged
merged 1 commit into from Aug 21, 2018
Merged

haskellPackages.mattermost-api: skip check #45053

merged 1 commit into from Aug 21, 2018

Conversation

carlosdagos
Copy link
Member

Motivation for this change

Tests require a mattermost server running in docker. Better to skip them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Aug 15, 2018

Retriggering eval due to master failure
@GrahamcOfBorg eval

@mpickering
Copy link
Contributor

I think this fix should go inconfiguration-nix.nix which is for "overrides which are needed because of Nix. "

@carlosdagos
Copy link
Member Author

I debated with myself for a while where to place this, and I don't think this override is because of Nix entirely since requiring a mattermost server is very similar to what happens with the mysql libs, for example.

Additionally, in configuration-nix.nix it is stated:

# [..] one of the following reasons:
#
# * packages that hard code the location of native libraries, so they need to be patched/
# supplied the patch explicitly
# * passing native libraries that are not detected correctly by cabal2nix
# * test suites that fail due to some features not available in the nix sandbox
# (networking being a common one)

I don't think those apply to this case, except for maybe the 3rd one?

Thanks for having a look @mpickering. I'm happy to move this override if I'm mistaken 😄

@mpickering
Copy link
Contributor

Also see in configuration.nix - https://github.com/NixOS/nixpkgs/blob/a783f7f72560a3046f3b08f27ed2521b219eb059/pkgs/development/haskell-modules/configuration-nix.nix#L56

In my mind, configuration.nix is for things which are unlikely to be fixed but configuration-common.nix is for transient failures. You're right however that this distinction is not very clear.

@carlosdagos
Copy link
Member Author

Thanks @mpickering for pointing that one out. You make a good point. @peti what do you reckon? Thanks!

@peti
Copy link
Member

peti commented Aug 20, 2018

I agree with @mpickering.

@carlosdagos
Copy link
Member Author

Amended the commit. Thanks again for the help @mpickering and @peti 😄 Cheers

@basvandijk
Copy link
Member

@GrahamcOfBorg build haskellPackages.mattermost-api

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.mattermost-api

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.mattermost-api

Partial log (click to expand)

/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/libHSmattermost-api-40900.1.0-4lWgrrI2i4KJpndG6XUVQ5-ghc8.4.3.dylib: fixing dylib
strip is /nix/store/bg39mxc401qqxgjasxfgardi6xl2ikmc-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/2zn1l4cs06vy5wxrndpyyyxdjc57qvzf-mattermost-api-40900.1.0-doc
/nix/store/z9y593dwm41hlyr07kiycvvpwp4dd0ma-mattermost-api-40900.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.mattermost-api

Partial log (click to expand)

strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/riwzipsf3nwwfvg0pl2g77mzm8k8znmi-mattermost-api-40900.1.0/lib
patching script interpreter paths in /nix/store/riwzipsf3nwwfvg0pl2g77mzm8k8znmi-mattermost-api-40900.1.0
checking for references to /build in /nix/store/riwzipsf3nwwfvg0pl2g77mzm8k8znmi-mattermost-api-40900.1.0...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/5s8x379fab3z6vq4v3d723r6lq77kwzf-mattermost-api-40900.1.0-doc
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5s8x379fab3z6vq4v3d723r6lq77kwzf-mattermost-api-40900.1.0-doc
checking for references to /build in /nix/store/5s8x379fab3z6vq4v3d723r6lq77kwzf-mattermost-api-40900.1.0-doc...
/nix/store/riwzipsf3nwwfvg0pl2g77mzm8k8znmi-mattermost-api-40900.1.0

@basvandijk basvandijk merged commit 170b8a8 into NixOS:master Aug 21, 2018
@basvandijk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carlosdagos @srhb @mpickering @peti @basvandijk @GrahamcOfBorg