New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for yaml bundles definitions #3136
Conversation
Baseline is failing because:
I have tested locally against my personal setup |
👎 from me. What benefits does this have over the old format? I can’t think of any. Since we haven’t migrated config to YAML yet, there is no point in forcing it for simple files like
Good catch, I fixed this on master.
You can’t always do that with JS — for example, if |
Per your point, I have removed the sorting. |
The primary benefit over the existing format, and the reason I want this change, is that it allows for bundle inputs to be on separate lines. During theme development, this helps me in two big ways:
In both cases, having to read a long line of entries, especially where I have to visually parse between I initially considered modifying the existing format to support multiple lines per bundle but supporting yaml seemed much easier and more foolproof. |
I don’t think using YAML and making it the new default is worth the effort, especially because (a) YAML is not our base dependency, (b) this is minor, “backstage” stuff. I could, however, accept a PR in which |
Instead of changing the file format, I have opened #3137 to change the underlying parser to add additional features while maintaining strict backwards compatibility and without adding new base dependencies. |
Pull Request Checklist
Description
This PR adds support for
bundles.yaml
orbundles.yml
as alternatives tobundles
files in themes.If both are present, the yaml files take precedence. If only
bundles
is present, behavior is unchanged.bundles.yaml
takes the form:and would replace
bundles
file of the form: