Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subversion: default to subversion_1_10 #44800

Merged
merged 1 commit into from Aug 9, 2018
Merged

subversion: default to subversion_1_10 #44800

merged 1 commit into from Aug 9, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Aug 9, 2018

Motivation for this change

1.10.2 has been released with minor bugfixes: 1.10 series seems stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: subversion

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/898y0xdc3jk8x6xp0g61f1040yxb6h4q-subversion-1.10.2-dev
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/898y0xdc3jk8x6xp0g61f1040yxb6h4q-subversion-1.10.2-dev
checking for references to /build in /nix/store/898y0xdc3jk8x6xp0g61f1040yxb6h4q-subversion-1.10.2-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/3ma0idxbv746wysyx9fzkzps4y43vgx7-subversion-1.10.2-man
gzipping man pages under /nix/store/3ma0idxbv746wysyx9fzkzps4y43vgx7-subversion-1.10.2-man/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3ma0idxbv746wysyx9fzkzps4y43vgx7-subversion-1.10.2-man
checking for references to /build in /nix/store/3ma0idxbv746wysyx9fzkzps4y43vgx7-subversion-1.10.2-man...
/nix/store/9szbbcr0f6a6hman3dgvfrc89pivzhq2-subversion-1.10.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: subversion

Partial log (click to expand)

Patching '/nix/store/q1k54ky6jn1p318ddclg5jz7xf8n5hg0-subversion-1.10.2-dev/share/pkgconfig/libsvn_wc.pc' includedir to output /nix/store/q1k54ky6jn1p318ddclg5jz7xf8n5hg0-subversion-1.10.2-dev
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8yqx59zdgm83g64n452x5sf08xlsgzgd-subversion-1.10.2/lib  /nix/store/8yqx59zdgm83g64n452x5sf08xlsgzgd-subversion-1.10.2/bin
patching script interpreter paths in /nix/store/8yqx59zdgm83g64n452x5sf08xlsgzgd-subversion-1.10.2
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/q1k54ky6jn1p318ddclg5jz7xf8n5hg0-subversion-1.10.2-dev
gzipping man pages under /nix/store/3k7i5nly37xhv254321hj72w76rc12bs-subversion-1.10.2-man/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/3k7i5nly37xhv254321hj72w76rc12bs-subversion-1.10.2-man
/nix/store/8yqx59zdgm83g64n452x5sf08xlsgzgd-subversion-1.10.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: subversion

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/h7zj207lh82ffzs6h60dqbkhf150829w-subversion-1.10.2-dev
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h7zj207lh82ffzs6h60dqbkhf150829w-subversion-1.10.2-dev
checking for references to /build in /nix/store/h7zj207lh82ffzs6h60dqbkhf150829w-subversion-1.10.2-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/x60dswh510z6ngmmadm6hkqsf61cw7n1-subversion-1.10.2-man
gzipping man pages under /nix/store/x60dswh510z6ngmmadm6hkqsf61cw7n1-subversion-1.10.2-man/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/x60dswh510z6ngmmadm6hkqsf61cw7n1-subversion-1.10.2-man
checking for references to /build in /nix/store/x60dswh510z6ngmmadm6hkqsf61cw7n1-subversion-1.10.2-man...
/nix/store/7c88nvaam70sgnpcnsgkwc93qh7fki3j-subversion-1.10.2

Mic92
Mic92 reviewed Aug 9, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -18498,7 +18498,7 @@ with pkgs;
})
subversion18 subversion19 subversion_1_10;

subversion = pkgs.subversion19;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changelog it also seems that subversion19 is not an LTS release, so we probably want to remove it before the next release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it seems that 1.9 will be supported until 1.11 is released. I think we should keep 1.9, but remove 1.8.

@orivej-nixos orivej-nixos merged commit 67b9a11 into NixOS:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orivej @GrahamcOfBorg @Mic92 @orivej-nixos