Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysrim: init at 0.5.8 #44756

Merged
merged 1 commit into from Aug 8, 2018
Merged

pythonPackages.pysrim: init at 0.5.8 #44756

merged 1 commit into from Aug 8, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 8, 2018

Motivation for this change

add package needed for scientific calculations.

Things done
  • compatible with 2.7, 3+
  • tests are not run due to requiring git lfs download of repository
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner August 8, 2018 20:30
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pysrim python3.pkgs.pysrim

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.pysrim, python3.pkgs.pysrim

Partial log (click to expand)

    return self.obtain(req, installer)
  File "/nix/store/pyvd05namlbgacai4vr5xcpy5wlhhcb2-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1068, in obtain
    return installer(requirement)
  File "/nix/store/pyvd05namlbgacai4vr5xcpy5wlhhcb2-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/dist.py", line 581, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/pyvd05namlbgacai4vr5xcpy5wlhhcb2-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 670, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
builder for '/nix/store/qx1af836n5017y9n6w43pag3if5b9zk2-python3.6-pysrim-0.5.8.drv' failed with exit code 1
error: build of '/nix/store/8dbvlrrrg69psrn4vl6x22ljf1p0wlsk-python2.7-pysrim-0.5.8.drv', '/nix/store/qx1af836n5017y9n6w43pag3if5b9zk2-python3.6-pysrim-0.5.8.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.pysrim, python3.pkgs.pysrim

Partial log (click to expand)

    return self.obtain(req, installer)
  File "/nix/store/vb2s9qiv4l9gr2q152sn6kfy30gx10kx-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1068, in obtain
    return installer(requirement)
  File "/nix/store/vb2s9qiv4l9gr2q152sn6kfy30gx10kx-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/dist.py", line 581, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/vb2s9qiv4l9gr2q152sn6kfy30gx10kx-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 670, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
builder for '/nix/store/jirxxs8w5df0c5239zlxzpns5jw5g0dr-python3.6-pysrim-0.5.8.drv' failed with exit code 1
error: build of '/nix/store/g8dxa982laklbaw7rxi62paqizhhnril-python2.7-pysrim-0.5.8.drv', '/nix/store/jirxxs8w5df0c5239zlxzpns5jw5g0dr-python3.6-pysrim-0.5.8.drv' failed

@dotlambda
Copy link
Member

distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')

Again, pytestrunner is missing. Without sandboxing, it will be downloaded during build.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pysrim, python3.pkgs.pysrim

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/90dphw34r4k0j8hdifrhj4gqsq4d7pw1-python2.7-pysrim-0.5.8/lib
patching script interpreter paths in /nix/store/90dphw34r4k0j8hdifrhj4gqsq4d7pw1-python2.7-pysrim-0.5.8
Successfully installed pysrim-0.5.8
/private/tmp/nix-build-python3.6-pysrim-0.5.8.drv-0/pysrim-0.5.8
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/asykibvji0f6z1hh4h00f00nn5qdsxxa-python3.6-pysrim-0.5.8/lib
patching script interpreter paths in /nix/store/asykibvji0f6z1hh4h00f00nn5qdsxxa-python3.6-pysrim-0.5.8
/nix/store/90dphw34r4k0j8hdifrhj4gqsq4d7pw1-python2.7-pysrim-0.5.8
/nix/store/asykibvji0f6z1hh4h00f00nn5qdsxxa-python3.6-pysrim-0.5.8

@costrouc
pythonPackages.pysrim: init at 0.5.8
12d98b8 
 - compatible with 2.7, 3+
 - tests are not run due to requiring git lfs download of repository
@costrouc
Copy link
Member Author

costrouc commented Aug 8, 2018

Learned to use --option sandbox true with nix build thanks for the pointer and it did help me find the issue. This push should fix the issue.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pysrim python3.pkgs.pysrim

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pysrim, python3.pkgs.pysrim

Partial log (click to expand)

Successfully installed pysrim-0.5.8
/tmp/nix-build-python3.6-pysrim-0.5.8.drv-0/pysrim-0.5.8
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3rs2sdmkkjylydb3s7d091b01m6wh2sg-python3.6-pysrim-0.5.8
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3rs2sdmkkjylydb3s7d091b01m6wh2sg-python3.6-pysrim-0.5.8/lib 
patching script interpreter paths in /nix/store/3rs2sdmkkjylydb3s7d091b01m6wh2sg-python3.6-pysrim-0.5.8
checking for references to /tmp/nix-build-python3.6-pysrim-0.5.8.drv-0 in /nix/store/3rs2sdmkkjylydb3s7d091b01m6wh2sg-python3.6-pysrim-0.5.8...
/nix/store/kpa7qk3ask57gagw6q3arggyvgd6pmhx-python2.7-pysrim-0.5.8
/nix/store/3rs2sdmkkjylydb3s7d091b01m6wh2sg-python3.6-pysrim-0.5.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pysrim, python3.pkgs.pysrim

Partial log (click to expand)

Successfully installed pysrim-0.5.8
/build/pysrim-0.5.8
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ydz4lx6p1dghdcnl1wxcd8yzlzaw3iy3-python3.6-pysrim-0.5.8
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ydz4lx6p1dghdcnl1wxcd8yzlzaw3iy3-python3.6-pysrim-0.5.8/lib
patching script interpreter paths in /nix/store/ydz4lx6p1dghdcnl1wxcd8yzlzaw3iy3-python3.6-pysrim-0.5.8
checking for references to /build in /nix/store/ydz4lx6p1dghdcnl1wxcd8yzlzaw3iy3-python3.6-pysrim-0.5.8...
/nix/store/kcjihj69xwghgz4azqd6zdfwllddgqd4-python2.7-pysrim-0.5.8
/nix/store/ydz4lx6p1dghdcnl1wxcd8yzlzaw3iy3-python3.6-pysrim-0.5.8

@dotlambda dotlambda merged commit 1d46027 into NixOS:master Aug 8, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pysrim, python3.pkgs.pysrim

Partial log (click to expand)

Requirement already satisfied: numpy>=1.10.0 in /nix/store/ir6kz471ijjc6mpcy0q5690q9jabkwnv-python3.6-numpy-1.14.5/lib/python3.6/site-packages (from pysrim==0.5.8) (1.14.5)
Installing collected packages: pysrim
Successfully installed pysrim-0.5.8
/private/tmp/nix-build-python3.6-pysrim-0.5.8.drv-0/pysrim-0.5.8
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jjp589jnjz6q00kpijm52zjb97ahnz25-python3.6-pysrim-0.5.8/lib
patching script interpreter paths in /nix/store/jjp589jnjz6q00kpijm52zjb97ahnz25-python3.6-pysrim-0.5.8
/nix/store/m6w0mviijdi23hg5lbw6cbzr10y066q1-python2.7-pysrim-0.5.8
/nix/store/jjp589jnjz6q00kpijm52zjb97ahnz25-python3.6-pysrim-0.5.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @dotlambda @GrahamcOfBorg