mention nix-store --query --roots when a path cannot be deleted
#2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is still relevant. Could someone have a look? @NixOS/nix-core |
|
I think this would be a pragmatic and useful quickfix, considering that #2046 has stalled. How could this PR be helped to get it merged? |
|
Make it known to potential reviewers. Maybe mention it on irc/matrix? I don't want to come over as spammy with the mentions I used in this PR already. |
infinisil
reviewed
Sep 9, 2019
| throw Error(format("cannot delete path '%1%' since it is still alive") % i); | ||
| throw Error(format( | ||
| "cannot delete path '%1%' since it is still alive. " | ||
| "To find out why use: " |
There was a problem hiding this comment.
I think this should be
Suggested change
| "To find out why use: " | |
| "To find out why, use: " |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up on the discussions on PR #2046, this PR will mention the usage of
nix-store --query --rootswhenevernix-storecannot delete a path due to itstill being alive.
This was suggested by @edolstra, because it is not straightforward
whether a path is alive due to it being referred to by a GC root, it being a GC root or
it being referred to by GC in-memory.