Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licenses: libzip, minizip, bzip2, zip #44813

Merged
merged 5 commits into from Aug 9, 2018
Merged

Add licenses: libzip, minizip, bzip2, zip #44813

merged 5 commits into from Aug 9, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Add missing licenses to 'zip' topic packages (see #43716)

Things done
  • Add licenses
  • Update homepage where applicable
  • Remove bzip2 homepage (seems to be gone: http://bzip.org/)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa force-pushed the licenses-zip branch 2 times, most recently from b6af4a4 to 1e27ed2 Compare August 9, 2018 09:36
@pSub pSub merged commit 1d4de0d into NixOS:master Aug 9, 2018
@pSub
Copy link
Member

pSub commented Aug 9, 2018

Thanks. I've ticked the corresponding boxes in #43716.

@markuskowa markuskowa deleted the licenses-zip branch August 9, 2018 11:54
@ivan-m ivan-m mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @pSub @GrahamcOfBorg