Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material science packages (init and update): lammps, python - ase, pymatgen-lammps, lammps-cython, dftfit #44752

Merged
merged 12 commits into from Aug 25, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 8, 2018

Motivation for this change

I wanted to be able to do all my research using nix for the package management on hpc clusters. To do this I need to package dftfit which has many dependencies. With this work my package is now available.

Things done
  • lammps: 16Feb16 -> patch_2Aug2018
  • pythonPackages.ase: init at 3.16.2
  • pythonPackages.pymatgen-lammps: init at 0.4.5
  • pythonPackages.lammps-cython: init at 0.5.7
  • pythonPackages.dftfit: init at 0.4.11
  • pythonPackages.pygmo: init at 2.8
  • pagmo: init at 2.8
  • pythonPackages.pathlib: refactor move to python-modules
  • pythonPackages.docutils: refactor move to python-modules
  • pythonPackages.pytest-benchmark: init at 3.1.1
  • pythonPackages.statistics: init at 1.0.3.5
  • pythonPackages.py-cpuinfo: init at 4.0.0

All packages pass with sandbox and work with python 2.7, 3+ if compatible. Every attempt was made to make all tests run and pass. But each package was checked to make sure that it worked.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc changed the title lammps: 16Feb16 -> patch_2Aug2018 lammps: 16Feb16 -> patch_2Aug2018 + new material science python packages (ase, pymatgen-lammps, lammps-cython, dftfit) Aug 9, 2018
Major changes and update to lammps build

 - using fetchFromGitHub to get source instead of lammps mirror
 - configurable lammps packages included and includes for compilation
 - cleaner build script
 - preserving the executable, shared library names, and include headers
 - fetchFromGitHub to run all tests
 - all tests pass
 - package does not come with tests
 - fetchFromGitHub to get all tests
 - all tests pass
 - python 2.7, 3+
 - moved docutils to `python-modules`
 - python 2.7, 3+
 - all tests pass
 - package is depricated but is required by a package
 - tests just hang so skipping tests
 - python 2.7, 3+
 - repository is in gitlab so had to fetchurl
 - c++ headers for library
 - parallel optimization framework
 - all tests but 1/55 pass so skipping tests
 - python 2.7, 3+
 - skipping tests becuase none are easy to run (require some parallel workers)
 - fetchFromgitHub so that running tests in future is possible
 - all tests pass
 - python 3+
 - fetchurl since package is on gitlab
 - python 3+
 - all tests pass
 - fetchurl since project based in gitlab and to run tests
 - tests require lfs download so not run
 - python 3+
 - fetchpypi since fetchurl is large download
@costrouc costrouc requested a review from FRidh as a code owner August 10, 2018 20:49
@costrouc costrouc changed the title lammps: 16Feb16 -> patch_2Aug2018 + new material science python packages (ase, pymatgen-lammps, lammps-cython, dftfit) material science packages (init and update): lammps, python - ase, pymatgen-lammps, lammps-cython, dftfit Aug 10, 2018
@costrouc
Copy link
Member Author

costrouc commented Aug 10, 2018

Pull request is now complete and ready for reviews and merging.

version = "3.16.2";
pname = "ase";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi is the preferred fetcher

@FRidh FRidh changed the base branch from master to staging August 25, 2018 16:58
@FRidh FRidh changed the base branch from staging to python-unstable August 25, 2018 16:59
@FRidh
Copy link
Member

FRidh commented Aug 25, 2018

@GrahamcOfBorg build python.pkgs.docutils python3.pkgs.docutils python.pkgs.pathlib python3.pkgs.pathlib python.pkgs.statistics python3.pkgs.statistics

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python.pkgs.docutils, python3.pkgs.docutils, python.pkgs.pathlib, python.pkgs.statistics, python3.pkgs.statistics

The following builds were skipped because they don't evaluate on x86_64-linux: python3.pkgs.pathlib

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vpzj92prvc02xwywjhdk1ph6yplbpn7x-python3.6-statistics-1.0.3.5
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vpzj92prvc02xwywjhdk1ph6yplbpn7x-python3.6-statistics-1.0.3.5/lib
patching script interpreter paths in /nix/store/vpzj92prvc02xwywjhdk1ph6yplbpn7x-python3.6-statistics-1.0.3.5
checking for references to /build in /nix/store/vpzj92prvc02xwywjhdk1ph6yplbpn7x-python3.6-statistics-1.0.3.5...
/nix/store/fmnc9rp2w55kbz50mnq4fc0y4a374fdj-python2.7-docutils-0.14
/nix/store/pzvnw72cgd57jmrnr3wqc18g6kd23505-python3.6-docutils-0.14
/nix/store/a87kmswkjp2xdgwdhwrgnc2j1n88rvfa-python2.7-pathlib-1.0.1
/nix/store/m30mzqi3n90l824slsrsq410dirclsz1-python2.7-statistics-1.0.3.5
/nix/store/vpzj92prvc02xwywjhdk1ph6yplbpn7x-python3.6-statistics-1.0.3.5

@FRidh FRidh changed the base branch from python-unstable to staging August 25, 2018 17:03
@FRidh FRidh merged commit c71942e into NixOS:staging Aug 25, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python.pkgs.docutils, python3.pkgs.docutils, python.pkgs.pathlib, python.pkgs.statistics, python3.pkgs.statistics

The following builds were skipped because they don't evaluate on aarch64-linux: python3.pkgs.pathlib

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/fasm895bni2k6zznnjjjy3cj8lppqkkj-python3.6-statistics-1.0.3.5
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fasm895bni2k6zznnjjjy3cj8lppqkkj-python3.6-statistics-1.0.3.5/lib
patching script interpreter paths in /nix/store/fasm895bni2k6zznnjjjy3cj8lppqkkj-python3.6-statistics-1.0.3.5
checking for references to /build in /nix/store/fasm895bni2k6zznnjjjy3cj8lppqkkj-python3.6-statistics-1.0.3.5...
/nix/store/nylbyisf319w0vnvs19idin3xa3i5lvw-python2.7-docutils-0.14
/nix/store/csplvwmqzsl2l60r1pn4b07dx35ly565-python3.6-docutils-0.14
/nix/store/xa1ypps67ivyq2nbf8vfxpm27fis4gc5-python2.7-pathlib-1.0.1
/nix/store/j384d4xxa7wis7yj78710mw98a76xv0x-python2.7-statistics-1.0.3.5
/nix/store/fasm895bni2k6zznnjjjy3cj8lppqkkj-python3.6-statistics-1.0.3.5

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: python.pkgs.docutils, python3.pkgs.docutils, python.pkgs.pathlib, python.pkgs.statistics, python3.pkgs.statistics

The following builds were skipped because they don't evaluate on x86_64-darwin: python3.pkgs.pathlib

Partial log (click to expand)

cannot build derivation '/nix/store/6vbxb4lkxq1wzxqsh5pr60aw282q3z1j-python2.7-bootstrapped-pip-18.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/cwah35j710r04fjbxgc22cwsazrfqyzd-python3.6-bootstrapped-pip-18.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/cnzxqap2vxxzjncdmanadbfb0xf6dwij-python2.7-setuptools-40.2.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/mx3npln0gi299f30c77z8gqd58m0rfv7-python3.6-setuptools-40.2.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/l1340102mhicwhgfww0nnz0vpnrdvpky-python2.7-docutils-0.14.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/3jrqls5b4b317l6qcqpgabjya2p8qmfc-python2.7-pathlib-1.0.1.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/88v9mm1488qqyisi2lz9q6kqiff84g57-python3.6-docutils-0.14.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/pjiaf1yinzj6h1yyjckjf72pbach1h8n-python2.7-statistics-1.0.3.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/qslzyaixy609asqs1ql10b1wkgvx9n88-python3.6-statistics-1.0.3.5.drv': 8 dependencies couldn't be built
error: build of '/nix/store/3jrqls5b4b317l6qcqpgabjya2p8qmfc-python2.7-pathlib-1.0.1.drv', '/nix/store/88v9mm1488qqyisi2lz9q6kqiff84g57-python3.6-docutils-0.14.drv', '/nix/store/l1340102mhicwhgfww0nnz0vpnrdvpky-python2.7-docutils-0.14.drv', '/nix/store/pjiaf1yinzj6h1yyjckjf72pbach1h8n-python2.7-statistics-1.0.3.5.drv', '/nix/store/qslzyaixy609asqs1ql10b1wkgvx9n88-python3.6-statistics-1.0.3.5.drv' failed

@costrouc costrouc deleted the costrouc/lammps-update branch August 27, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants