Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor: fix failing Hydra build #44011

Merged
merged 1 commit into from Jul 23, 2018
Merged

tor: fix failing Hydra build #44011

merged 1 commit into from Jul 23, 2018

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Jul 23, 2018

Motivation for this change

nixos-unstable and nixos-unstable-small have been stuck for 9 days:

https://hydra.nixos.org/build/78095656

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Jul 23, 2018
View reviewed changes
pkgs/tools/security/tor/default.nix
@@ -50,7 +50,6 @@ stdenv.mkDerivation rec {
inherit (stdenv) lib;
inherit
writeScript
runCommand
Copy link
Member

@Mic92 Mic92 Jul 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove runCommand above in the header of this file?

Copy link
Contributor Author

@mkaito mkaito Jul 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure I missed that. Done.

@Mic92 Mic92 merged commit b80c56e into NixOS:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkaito @Mic92 @GrahamcOfBorg