Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: servo/webrender
base: c3b9939bd5bf
Choose a base ref
...
head repository: servo/webrender
compare: d2b7cac4dcae
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jul 20, 2018

  1. Copy the full SHA
    13249af View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. Auto merge of #2920 - nical:debug-shader-build, r=kvark

    Don't panic when compiling the debug overlay shaders fail.
    
    Fixes #2808.
    There is always going to be a silly driver out there that will fail for whatever reason so let's not panic for something that isn't important to the user.
    I did leave the unwrap in wrench sort of on purpose because in the unlikely event that someone using wrench hits the driver bug, they'll be in a much better place to fix or report the issue than our average user, and if we are lucky enough to hit this kind of bug a developer's machine we'll be able can try to fix it.
    
    I'm tempted to remove the debug_render feature. It's not buying much since the shader is compiled lazily and it adds noise to the code (and feature flags are annoyingly easy to break).
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2920)
    <!-- Reviewable:end -->
    bors-servo committed Jul 23, 2018
    Copy the full SHA
    d2b7cac View commit details
    Browse the repository at this point in the history