Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: add optional support for MySQL and the Dovecot authenticator #44030

Merged
merged 1 commit into from Jul 30, 2018
Merged

exim: add optional support for MySQL and the Dovecot authenticator #44030

merged 1 commit into from Jul 30, 2018

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jul 23, 2018

Motivation for this change

Exim offers a lot of options, some of which, some people use.
In this case, "some people" is me and "some options" are MySQL and the Dovecot authenticator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Jul 23, 2018
View reviewed changes
pkgs/servers/mail/exim/default.nix
{ coreutils, db, fetchurl, openldap, openssl, pcre, perl, pkgconfig, stdenv
, enableLDAP ? false
{ coreutils, db, fetchurl, openssl, pcre, perl, pkgconfig, stdenv
, enableLDAP ? false, openldap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have some of them enabled by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but considering nobody else seems to have needed them so far, I am not sure that is necessary.

@Mic92 Mic92 merged commit 86d7d96 into NixOS:master Jul 30, 2018
@ajs124 ajs124 deleted the exim_mysql_dovecot branch July 31, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @Mic92 @GrahamcOfBorg