Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager-vpnc: 1.2.4 -> 1.2.6 #44032

Merged
merged 1 commit into from Jul 24, 2018
Merged

networkmanager-vpnc: 1.2.4 -> 1.2.6 #44032

merged 1 commit into from Jul 24, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jul 23, 2018 •
edited

Motivation for this change

fixes CVE-2018-10900

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir andir requested a review from jtojnar July 23, 2018 21:24
@andir
Copy link
Member Author

andir commented Jul 23, 2018

@flokli has tested this since he has a valid Cisco VPN confguration.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 23, 2018

Changelog looks fine: https://download.gnome.org/sources/NetworkManager-vpnc/1.2/NetworkManager-vpnc-1.2.6.news

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: networkmanager-vpnc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: networkmanager-vpnc

Partial log (click to expand)

shrinking /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpn-plugin-vpnc-editor.so
shrinking /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/lib/NetworkManager/libnm-vpnc-properties.so
shrinking /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-service
shrinking /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-service-vpnc-helper
shrinking /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/libexec/nm-vpnc-auth-dialog
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/lib  /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6/libexec
patching script interpreter paths in /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6
checking for references to /build in /nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6...
/nix/store/sbwzwjkwl4rhqcr7zlvdjk43i8pr4mlr-NetworkManager-vpnc-gnome-1.2.6

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: networkmanager-vpnc

Partial log (click to expand)

   Compiling backtrace v0.3.6
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.27.0-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.27.0-src/src/libsyntax_ext)
building of '/nix/store/dakhciw1l1sjg3aq3lsbi5zws5nbf6aw-rustc-1.27.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/cgddwbffkzq2vkmrp4ja0r3h6skk9mxi-cargo-1.27.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d1ixd3wxrjwdyafpw1nwnd5cxp7cg2ka-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wjrc526akcfn9vmxjwk3cdh6k9k94c4d-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f7i3rl1blzg9l9sbkh1fgbl4skw1ywgi-network-manager-applet-1.8.14.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vjrfwm9m3gmv5n2n2286a68ys7hmbsvm-NetworkManager-vpnc-gnome-1.2.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/vjrfwm9m3gmv5n2n2286a68ys7hmbsvm-NetworkManager-vpnc-gnome-1.2.6.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jul 23, 2018

diff: https://gitlab.gnome.org/GNOME/NetworkManager-vpnc/compare/1.2.4...1.2.6

@Mic92 Mic92 merged commit a587aab into NixOS:master Jul 24, 2018
@Mic92
Copy link
Member

Mic92 commented Jul 24, 2018

tested using my university VPN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @jtojnar @GrahamcOfBorg @Mic92