pet: init at 0.3.2 #44033
Merged
pet: init at 0.3.2 #44033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
requested changes
Jul 24, 2018
|
|
||
| goPackagePath = "github.com/knqyf263/pet"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
Please use fetchFromGitHub instead of fetchurl because it relies on the hash of the contents of the repository instead of the hash of a tarball, and it would allow us to fix all GitHub src fetchers, if GitHub changes something about how it works.
|
@GrahamcOfBorg build pet |
|
Success on x86_64-linux (full log) Attempted: pet Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pet Partial log (click to expand)
|
|
@GrahamcOfBorg build pet |
|
@ryantm updated it to use |
|
@kalbasit You have to be on an approved list in https://github.com/NixOS/ofborg to issue commands to the bot (security and such!). @GrahamcOfBorg build pet |
|
@ryantm Thanks for the tip, I'll file a PR to add myself there. I don't understand why would this PR breaks the eval of arena. |
|
@GrahamcOfBorg eval |
|
@GrahamcOfBorg build pet |
ryantm
approved these changes
Jul 24, 2018
|
Success on aarch64-linux (full log) Attempted: pet Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: pet Partial log (click to expand)
|
|
@ryantm I see. I rebased over master and pushed again. |
|
For future reference, I think rebasing is unnecessary. @GrahamcOfBorg build pet |
|
Success on aarch64-linux (full log) Attempted: pet Partial log (click to expand)
|
|
@ryantm sounds good, just wanted the record clean for the PR. |
|
Success on x86_64-linux (full log) Attempted: pet Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: pet Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pet: CLI Snippet Manager. Simple command-line snippet manager, written in Go.
https://github.com/knqyf263/pet
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)