stumpish: init at 0.0.1 #44016
Merged
stumpish: init at 0.0.1 #44016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jul 23, 2018
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/stumpwm/stumwm-contrib; |
| chmod +x $out/bin/stumpish | ||
| ''; | ||
|
|
||
| postFixup = '' |
There was a problem hiding this comment.
Using a patch file with substituteAll would probably be cleaner.
| sha256 = "1dxzsnir3158p8y2128s08r9ca0ywr9mcznivmhn1lycw8mg4nfl"; | ||
| }; | ||
|
|
||
| phases = [ "buildPhase" "installPhase" "postFixup" ]; |
There was a problem hiding this comment.
Manually setting phases is frowned upon #28910
|
@jtojnar I updated |
jtojnar
reviewed
Jul 31, 2018
| ''; | ||
|
|
||
| installPhase = '' | ||
| cp $src/util/stumpish/stumpish $out/bin |
There was a problem hiding this comment.
You need to drop $src/. It contains the unpatched file.
jtojnar
reviewed
Jul 31, 2018
|
|
||
| installPhase = '' | ||
| cp $src/util/stumpish/stumpish $out/bin | ||
| chmod +x $out/bin/stumpish |
There was a problem hiding this comment.
This should not be necessary.
|
@jtojnar Is this better? |
|
It does seem so. |
|
@jtojnar Thanks! |
|
Do you think we can merge this now? |
|
@jtojnar Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)