Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable MutationObserver by default. #21232

Merged
merged 1 commit into from Jul 27, 2018
Merged

Enable MutationObserver by default. #21232

merged 1 commit into from Jul 27, 2018

Conversation

jdm
Copy link
Member

@jdm jdm commented Jul 23, 2018 •
edited

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 23, 2018
@jdm
Copy link
Member Author

jdm commented Jul 23, 2018

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 97ff88c with merge 9306781...

bors-servo pushed a commit that referenced this pull request Jul 23, 2018
Auto merge of #21232 - servo:jdm-patch-22, r=<try>
9306781 
Enable MutationObserver by default.

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21232)
<!-- Reviewable:end -->
@jdm jdm added this to In progress in A-Frame support Jul 23, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 23, 2018
@asajeffrey
Copy link
Member

You can r=me on this.

@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Jul 25, 2018
@jdm
Copy link
Member Author

jdm commented Jul 25, 2018

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

📌 Commit c96b137 has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 25, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit c96b137 with merge 2e5432e...

bors-servo pushed a commit that referenced this pull request Jul 25, 2018
Auto merge of #21232 - servo:jdm-patch-22, r=asajeffrey
2e5432e 
Enable MutationObserver by default.

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21232)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 25, 2018
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 25, 2018
@jdm
Copy link
Member Author

jdm commented Jul 25, 2018

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

📌 Commit 5d943c6 has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 25, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 5d943c6 with merge 53382f5...

bors-servo pushed a commit that referenced this pull request Jul 25, 2018
Auto merge of #21232 - servo:jdm-patch-22, r=asajeffrey
53382f5 
Enable MutationObserver by default.

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21232)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 25, 2018
@jdm
Copy link
Member Author

jdm commented Jul 25, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css1, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt4

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 25, 2018
@KiChjang
Copy link
Contributor

@bors-servo retry infra

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt4

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 26, 2018
@jdm
Copy link
Member Author

jdm commented Jul 26, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt4

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 26, 2018
@jdm
Copy link
Member Author

jdm commented Jul 27, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt4

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 27, 2018
@jdm
Copy link
Member Author

jdm commented Jul 27, 2018

@bors-servo retry

  • fixed rustup on the builder

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt4...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt4

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Jul 27, 2018
@jdm
Copy link
Member Author

jdm commented Jul 27, 2018

@bors-servo retry

  • builder should be fixed?

@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing 53382f5 to master...

@bors-servo bors-servo merged commit 5d943c6 into master Jul 27, 2018
@bors-servo bors-servo mentioned this pull request Jul 27, 2018
Merged
4 tasks
@atouchet atouchet moved this from In progress to Done in A-Frame support Jul 29, 2018
@SimonSapin SimonSapin deleted the jdm-patch-22 branch August 8, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
A-Frame support
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @bors-servo @asajeffrey @KiChjang @highfive