Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revelation: init at 0.4.14 #44022

Closed
wants to merge 2 commits into from
Closed

revelation: init at 0.4.14 #44022

wants to merge 2 commits into from

Conversation

trizinix
Copy link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@trizinix trizinix requested a review from FRidh as a code owner July 23, 2018 18:46
pSub
pSub requested changes Jul 23, 2018
View reviewed changes
pkgs/applications/misc/revelation/default.nix Outdated
version = "0.4.14";

src = fetchurl {
url = https://bitbucket.org/erikg/revelation/downloads/revelation-0.4.14.tar.bz2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use string interpolation to reduce the amount lines that need to be changed on updates. E.g.
url = https://bitbucket.org/erikg/revelation/downloads/${name}.tar.bz2;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

pkgs/applications/misc/revelation/default.nix Outdated

patches = [ ./remove-randpool.patch ];

buildInputs = [ pkgconfig gnome2.GConf intltool ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgconfig belongs to nativeBuildInputs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intltool maybe as well?

pkgs/applications/misc/revelation/default.nix Outdated
'';

meta = {
description = "A password manager for the GNOME desktop, released under the GNU GPL license";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "released under the GNU GPL license" is somehow redundant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the description from the website, but you are right, it is redundant.

pkgs/applications/misc/revelation/default.nix Outdated
sha256 = "2ab3d1d8bcc2f441feb58122ee6a0fe4070412228194843a180a7b1c9e910019";
};

patches = [ ./remove-randpool.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason behind removing randpool? Is the patch available upstream? If so please fetch it from there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project depends on pycrypt which has been replaced by the successor pycrpytdom in nixpkgs. Randpool is now completely removed from pycryptdom because it was used in an insecure way by many authors. So my choices were to either add the deprecated pycrypt or to apply a patch. The later seemed to be a lot less intrusive.

pkgs/development/python-modules/cracklib/default.nix Outdated
};

# No tests available
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to enable tests for the case upstream adds tests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was wrong, it does have tests but they depend on a dictionary that is not included in the archive from pypi (probably because it is relatively big).

FRidh
FRidh requested changes Jul 24, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One commit per package / logical unit

@trizinix
Copy link
Author

@FRidh Should I open a separate pull request for python-cracklib or are the two commits now alright?

@FRidh
Copy link
Member

FRidh commented Jul 27, 2018

Adding yourself to the maintainers list needs to be a separate commit as well.

@mmahut
Copy link
Member

mmahut commented Aug 10, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 5, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2021
@Artturin Artturin closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub requested changes

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@trizinix @FRidh @mmahut @pSub @ryantm @samueldr @GrahamcOfBorg @Artturin @Janik-Haag @aprys