flow: 0.76.0 -> 0.77.0 #44010
Closed
flow: 0.76.0 -> 0.77.0 #44010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
requested changes
Jul 23, 2018
|
|
||
| inherit (jbuilder) installPhase; | ||
|
|
||
| createFindLibDestdir = true; |
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "ppx_gen_rec"; | ||
| name = "ocaml-${pname}-${version}"; |
There was a problem hiding this comment.
Can you please add the OCaml version in the name string?
| description = "ocaml preprocessor that generates a recursive module"; | ||
| license = licenses.mit; | ||
| platforms = ocaml.meta.platforms or []; | ||
| maintainers = []; |
There was a problem hiding this comment.
Would you like adding yourself as maintainer?
|
@vbgl All done! |
|
@GrahamcOfBorg build flow |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: flow Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: flow Partial log (click to expand)
|
vbgl
approved these changes
Jul 23, 2018
|
Success on x86_64-darwin (full log) Attempted: flow Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream release. Facebook added yet another dependency they've built. It's my first attempt at adding an OCaml package, let me know if I did something wrong so I can fix it.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)