Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotop: works on non-Linux Unixes #44006

Merged
merged 1 commit into from Jul 23, 2018
Merged

gotop: works on non-Linux Unixes #44006

merged 1 commit into from Jul 23, 2018

Conversation

alyssais
Copy link
Member

Motivation for this change

From the README:

Working and tested on Linux and OSX, with Windows support being worked
on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais
gotop: works on non-Linux Unixes
20070b4 
From the README:

> Working and tested on Linux and OSX, with Windows support being worked
> on.
@Mic92
Copy link
Member

Mic92 commented Jul 23, 2018

@GrahamcOfBorg build gotop

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gotop

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jmgs55v937jhlsck37q80rdjp4r2y384-gotop-1.2.9-bin
shrinking /nix/store/jmgs55v937jhlsck37q80rdjp4r2y384-gotop-1.2.9-bin/bin/gotop
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jmgs55v937jhlsck37q80rdjp4r2y384-gotop-1.2.9-bin/bin
patching script interpreter paths in /nix/store/jmgs55v937jhlsck37q80rdjp4r2y384-gotop-1.2.9-bin
checking for references to /build in /nix/store/jmgs55v937jhlsck37q80rdjp4r2y384-gotop-1.2.9-bin...
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
/nix/store/jmgs55v937jhlsck37q80rdjp4r2y384-gotop-1.2.9-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gotop

Partial log (click to expand)

find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
find: '/nix/store/0aksg6krcdc7pdinip5fcnmbvidkgm5y-gotop-1.2.9': No such file or directory
/nix/store/g5xxvk2778sabylh1a4qapg3rpc9qy83-gotop-1.2.9-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gotop

Partial log (click to expand)

these paths will be fetched (0.75 MiB download, 2.67 MiB unpacked):
  /nix/store/h6m050l3kn2gpf7mcl7vyd7pj18cnsxm-gotop-1.2.9-bin
copying path '/nix/store/h6m050l3kn2gpf7mcl7vyd7pj18cnsxm-gotop-1.2.9-bin' from 'https://cache.nixos.org'...
/nix/store/h6m050l3kn2gpf7mcl7vyd7pj18cnsxm-gotop-1.2.9-bin

@Mic92 Mic92 merged commit 2f25e08 into NixOS:master Jul 23, 2018
@alyssais alyssais deleted the patch-4 branch July 26, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @Mic92 @GrahamcOfBorg