Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyre: 0.0.8 -> 0.0.10 #44023

Merged
merged 1 commit into from Jul 29, 2018
Merged

pyre: 0.0.8 -> 0.0.10 #44023

merged 1 commit into from Jul 29, 2018

Conversation

bbarker
Copy link
Contributor

@bbarker bbarker commented Jul 23, 2018

renamed pyre to pyre.bin; see upstream issue at:
facebook/pyre-check#79 (comment)

Motivation for this change
  • updating pyre version
  • renaming binary executable appropriately, to be compatible with future python support
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bbarker
pyre: 0.0.8 -> 0.0.10
62292d3 
renamed pyre to pyre.bin; see upstream issue at:
facebook/pyre-check#79 (comment)
@bbarker
Copy link
Contributor Author

bbarker commented Jul 23, 2018

cc @teh

teh
teh reviewed Jul 23, 2018
View reviewed changes
Copy link
Contributor

@teh teh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just two small comments.

pkgs/development/tools/pyre/default.nix
@@ -33,6 +33,7 @@ in stdenv.mkDerivation {
ppx_deriving_yojson
ocamlbuild
ppxlib
# python36Packages.python36Full # TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand the TODO with a closing condition? I'm not sure what needs to be done to resolve the TODO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, this is just for when we add the python client, pyre.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - LGTM after additional comment or removal. Thanks for the update!

pkgs/development/tools/pyre/default.nix
'';

# Note that we're not installing the typeshed yet.
# Improvement for a future version.
installPhase = ''
mkdir -p $out/bin
cp _build/all/main.native $out/bin/pyre
cp _build/all/main.native $out/bin/pyre.bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why rename this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the linked issue, the python client pyre expects this binary to be named pyre.bin. Currently we aren't installing the python client. Seems to depend on typeshed as you already noted.

@xeji
Copy link
Contributor

xeji commented Jul 29, 2018

@GrahamcOfBorg build pyre

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pyre

Partial log (click to expand)

 | ARCH_SIXTYFOUR=b:true
-> stderr:
Fatal error: exception (runtime-lib/runtime.ml.E "comparison failed"
  ((switch true) vs (switch false) (Loc src/config/discover.ml:205:15)))
Raised at file "src/configurator.ml", line 511, characters 13-22
Called from file "src/config/discover.ml", line 136, characters 2-1023
make: *** [Makefile:5: default] Error 1
builder for '/nix/store/bm8rl0vw3087prl7ls5ckc7nmaiiag35-ocaml4.06.1-core-0.11.1.drv' failed with exit code 2
cannot build derivation '/nix/store/5y8f3s9pyan905x06d5pjl2is5yzvq69-pyre-0.0.10.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5y8f3s9pyan905x06d5pjl2is5yzvq69-pyre-0.0.10.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pyre

Partial log (click to expand)

findlib: [WARNING] Interface main.cmi occurs in several directories: ., /nix/store/lc2fbm24b0vknlg1k72v5g4hkc239769-ocaml-4.06.1/lib/ocaml/compiler-libs
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9gkh6yavms6r8ywm4zd1a44y9zyiws22-pyre-0.0.10
shrinking /nix/store/9gkh6yavms6r8ywm4zd1a44y9zyiws22-pyre-0.0.10/bin/pyre.bin
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9gkh6yavms6r8ywm4zd1a44y9zyiws22-pyre-0.0.10/bin
patching script interpreter paths in /nix/store/9gkh6yavms6r8ywm4zd1a44y9zyiws22-pyre-0.0.10
checking for references to /build in /nix/store/9gkh6yavms6r8ywm4zd1a44y9zyiws22-pyre-0.0.10...
/nix/store/9gkh6yavms6r8ywm4zd1a44y9zyiws22-pyre-0.0.10

@xeji xeji merged commit e75a95d into NixOS:master Jul 29, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pyre

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh teh teh approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbarker @xeji @GrahamcOfBorg @teh