New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Introduce ServoSurface #21234
Conversation
Heads up! This PR modifies the following files:
|
throw new RuntimeException("Error: eglConfig() not Initialized"); | ||
} | ||
int[] attrib_list = {EGL_CONTEXT_CLIENT_VERSION, 3, EGL14.EGL_NONE}; | ||
mEglContext = EGL14.eglCreateContext(mEglDisplay, maEGLConfigs[0], EGL14.EGL_NO_CONTEXT, attrib_list, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check here if mEglContext is EGL_NO_CONTEXT for better error handling
1e9c928
to
27c0025
Compare
@MortimerGoro done. |
☔ The latest upstream changes (presumably #21242) made this pull request unmergeable. Please resolve the merge conflicts. |
449762f
to
56da1f6
Compare
@MortimerGoro can you give me a final review on the last commit? This has been tested with Crow. |
☔ The latest upstream changes (presumably #21250) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors-servo r=MortimerGoro |
📌 Commit c36b165 has been approved by |
Android: Introduce ServoSurface (WIP as it depends on 2 other PRs) Depends on #21199. Only last commit matters. r? @MortimerGoro Please look at ServoSurface.java. The rest is mostly some refactoring to share as much code as possible with ServoView. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21234) <!-- Reviewable:end -->
💔 Test failed - mac-rel-wpt1 |
@bors-servo retry |
⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1... |
💔 Test failed - mac-rel-wpt1 |
@bors-servo retry
|
Android: Introduce ServoSurface (WIP as it depends on 2 other PRs) Depends on #21199. Only last commit matters. r? @MortimerGoro Please look at ServoSurface.java. The rest is mostly some refactoring to share as much code as possible with ServoView. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21234) <!-- Reviewable:end -->
☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
(WIP as it depends on 2 other PRs)
Depends on #21199. Only last commit matters.
r? @MortimerGoro
Please look at ServoSurface.java. The rest is mostly some refactoring to share as much code as possible with ServoView.
This change is