Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkDerivation: depsHostBuild -> depsHostHost #44025

Merged
merged 1 commit into from Jul 23, 2018
Merged

mkDerivation: depsHostBuild -> depsHostHost #44025

merged 1 commit into from Jul 23, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jul 23, 2018 •
edited

Motivation for this change

depsHostBuild is not a thing, would never be a thing per the rules, and isn't used anywhere. This is just my typo, hitherto unnoticed because "host -> host" dependencies are by far the most obscure form.

I sort of feel trivial refactors like this should go straight to staging-next as they are unlikely to break anything, but somebody else should weigh in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
mkDerivation: depsHostBuild -> depsHostHost
ce2637c 
`depsHostBuild` is not a thing, would never be a thing per the rules,
and isn't used anywhere. This is just my typo, hitherto unnoticed
because "host -> host" dependencies are by far the most obscure form.
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: stdenv Standard environment label Jul 23, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Jul 23, 2018

I sort of feel trivial refactors like this should go straight to staging-next...

But this is going to cause everything to be rebuilt in staging-next? Then no, it defeats the entire purpose of staaging-next.

@matthewbauer
Copy link
Member

Yeah definitely stdenv changes should always go into staging.

@Ericson2314 Ericson2314 changed the base branch from staging-next to staging July 23, 2018 20:07
@Ericson2314
Copy link
Member Author

Ericson2314 commented Jul 23, 2018 •
edited

I thought the purpose was not breaking everything, not just rebuilding. My bad; retargetted.

@Ericson2314 Ericson2314 merged commit 611eefb into NixOS:staging Jul 23, 2018
@Ericson2314 Ericson2314 deleted the stdenv-deps-typo branch July 23, 2018 20:09
@Ericson2314 Ericson2314 added the 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @dezgeg @matthewbauer @GrahamcOfBorg