Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] neomutt: 20180223 -> 20180716 #44024

Merged
merged 1 commit into from Jul 23, 2018
Merged

[18.03] neomutt: 20180223 -> 20180716 #44024

merged 1 commit into from Jul 23, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jul 23, 2018

Motivation for this change

fixes CVE-2018-14362 CVE-2018-14359 CVE-2018-14358 CVE-2018-14357
CVE-2018-14356 CVE-2018-14355 CVE-2018-14354 CVE-2018-14353
CVE-2018-14352 CVE-2018-14351 CVE-2018-14350 CVE-2018-14349

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jul 23, 2018

@GrahamcOfBorg build neomutt

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neomutt

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/libexec  /nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/bin
patching script interpreter paths in /nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/share/doc/neomutt/keybase/pgpverify.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/share/doc/neomutt/keybase/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/share/doc/neomutt/keybase/decrypt.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/share/doc/neomutt/keybase/verify.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/share/doc/neomutt/keybase/pgpdecrypt.sh: interpreter directive changed from "/bin/sh" to "/nix/store/lw7xaqhakk0i1c631m3cvac3x4lc5gr5-bash-4.4-p12/bin/sh"
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716/libexec/neomutt/smime_keys: interpreter directive changed from " /usr/bin/perl -w" to "/nix/store/l6qc2aa8vf6sxpmi7cw28nrihhmmmvp5-perl-5.24.3/bin/perl -w"
checking for references to /build in /nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716...
/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: neomutt

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/libexec  /nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/bin
patching script interpreter paths in /nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/libexec/neomutt/smime_keys: interpreter directive changed from " /usr/bin/perl -w" to "/nix/store/l77x5q2wlgyklkgbd6x9ngyzpkb3k8i1-perl-5.24.3/bin/perl -w"
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/share/doc/neomutt/keybase/verify.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/share/doc/neomutt/keybase/pgpverify.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/share/doc/neomutt/keybase/pgpdecrypt.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/share/doc/neomutt/keybase/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716/share/doc/neomutt/keybase/decrypt.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i7pgaclm3qrcm9gpqxb5mbw9wsn7prd0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716...
/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neomutt

Partial log (click to expand)

/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: neomutt

Partial log (click to expand)

/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716

@andir andir merged commit 917906a into NixOS:release-18.03 Jul 23, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: neomutt

Partial log (click to expand)

  SMIME:             yes
  Notmuch:           yes
  Header Cache(s):   lmdb
  Lua:               no

building
build flags: -j1 -l1 SHELL=/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/bash
Makefile:21: *** target pattern contains no '%'.  Stop.
builder for '/nix/store/nljwgzvakh23dd2y4c93sx4siwlv1gib-neomutt-20180716.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/nljwgzvakh23dd2y4c93sx4siwlv1gib-neomutt-20180716.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: neomutt

Partial log (click to expand)

  SMIME:             yes
  Notmuch:           yes
  Header Cache(s):   lmdb
  Lua:               no

building
build flags: -j1 -l1 SHELL=/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/bash
Makefile:21: *** target pattern contains no '%'.  Stop.
builder for '/nix/store/nljwgzvakh23dd2y4c93sx4siwlv1gib-neomutt-20180716.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/nljwgzvakh23dd2y4c93sx4siwlv1gib-neomutt-20180716.drv' failed

@andir
Copy link
Member Author

andir commented Jul 23, 2018

@GrahamcOfBorg build neomutt

retrying to see if that darwin builder error is gone

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neomutt

Partial log (click to expand)

/nix/store/7g53p533w8arh5971y3zv03irzplbhb7-neomutt-20180716

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: neomutt

Partial log (click to expand)

  SMIME:             yes
  Notmuch:           yes
  Header Cache(s):   lmdb
  Lua:               no

building
build flags: -j1 -l1 SHELL=/nix/store/k5n19ccijsqdi5dwgblcck8x6b7ymlml-bash-4.4-p12/bin/bash
Makefile:21: *** target pattern contains no '%'.  Stop.
builder for '/nix/store/nljwgzvakh23dd2y4c93sx4siwlv1gib-neomutt-20180716.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/nljwgzvakh23dd2y4c93sx4siwlv1gib-neomutt-20180716.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: neomutt

Partial log (click to expand)

/nix/store/0xk1zryki59fm9fbjkiak04sz9dspcg0-neomutt-20180716

@andir andir deleted the 18.03/neomutt branch July 23, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg