Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-builders don't remove their build artifacts #21235

Closed
jdm opened this issue Jul 23, 2018 · 5 comments
Closed

Cross-builders don't remove their build artifacts #21235

jdm opened this issue Jul 23, 2018 · 5 comments
Labels
A-infrastructure

Comments

@jdm
Copy link
Member

jdm commented Jul 23, 2018

Not only do the android/arm jobs in buildbot_steps.yml not invoke the remove-build-directories script, but https://github.com/servo/saltfs/blob/master/ubuntu/files/remove-build-directories#L11 doesn't include the x86/arm/android targets that the build would generate instead of debug/release.
@highfive
Copy link

cc @aneeshusa

@jdm
Copy link
Member Author

jdm commented Jul 23, 2018

arm-unknown-linux-gnueabihf
android_aar
armv7-linux-androideabi
gradle
aarch64-unknown-linux-gnu

@SimonSapin
Copy link
Member

Is there a reason to remove specific sub-directories of target/ rather than the whole thing?

@jdm
Copy link
Member Author

jdm commented Jul 23, 2018

I do not remember my original reasoning for it.

@jdm
Copy link
Member Author

jdm commented Jul 29, 2018

servo/saltfs#870 will make the script usable on the cross builders.

@jdm jdm mentioned this issue Jul 30, 2018
Merged
bors-servo pushed a commit that referenced this issue Jul 30, 2018
Auto merge of #21286 - servo:jdm-patch-25, r=Manishearth
30f4c53 
Avoid frequent disk space errors on cross builders.

This is killing our CI throughput. Fixes #21235.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21286)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jul 30, 2018
Auto merge of #21286 - servo:jdm-patch-25, r=jdm
5fca9a9 
Avoid frequent disk space errors on cross builders.

This is killing our CI throughput. Fixes #21235.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21286)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jul 30, 2018
Auto merge of #21286 - servo:jdm-patch-25, r=jdm
b8b691d 
Avoid frequent disk space errors on cross builders.

This is killing our CI throughput. Fixes #21235.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21286)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @SimonSapin @highfive