Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and fix remaining MutationObserver test failures #21233

Open
jdm opened this issue Jul 23, 2018 · 5 comments
Open

Investigate and fix remaining MutationObserver test failures #21233

jdm opened this issue Jul 23, 2018 · 5 comments
Assignees
@KiChjang
Labels
A-content/dom Interacting with the DOM from web content

Comments

@jdm
Copy link
Member

jdm commented Jul 23, 2018 •
edited

https://github.com/servo/servo/blob/master/tests/wpt/metadata/dom/nodes/MutationObserver-attributes.html.ini
https://github.com/servo/servo/blob/master/tests/wpt/metadata/dom/nodes/MutationObserver-characterData.html.ini
https://github.com/servo/servo/blob/master/tests/wpt/metadata/dom/nodes/MutationObserver-document.html.ini
@jdm jdm added the A-content/dom Interacting with the DOM from web content label Jul 23, 2018
@jdm jdm mentioned this issue Jul 23, 2018
Merged
bors-servo pushed a commit that referenced this issue Jul 23, 2018
Auto merge of #21232 - servo:jdm-patch-22, r=<try>
9306781 
Enable MutationObserver by default.

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21232)
<!-- Reviewable:end -->
@emilio emilio mentioned this issue Jul 23, 2018
Merged
bors-servo pushed a commit that referenced this issue Jul 23, 2018
Auto merge of #21236 - emilio:mutation-observer, r=jdm
41f9f85 
script: A couple mutation observer fixes.

I felt like doing Servo stuff while trying to catch Gecko intermittents :)

This fixes most of #21233. I haven't dug into the other test.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21236)
<!-- Reviewable:end -->
@KiChjang
Copy link
Contributor

The first INI file doesn't exist anymore, and I've just built and ran the test on master -- all subtests passed locally.

@KiChjang
Copy link
Contributor

Same goes for the second INI file.

@jdm
Copy link
Member Author

jdm commented Jul 24, 2018

Yes, there were both fixed yesterday by #21236.

bors-servo pushed a commit that referenced this issue Jul 25, 2018
Auto merge of #21232 - servo:jdm-patch-22, r=asajeffrey
2e5432e 
Enable MutationObserver by default.

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21232)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jul 25, 2018
Auto merge of #21232 - servo:jdm-patch-22, r=asajeffrey
53382f5 
Enable MutationObserver by default.

All of the WebIDL APIs are implemented, so we might as well have it enabled by default now. I've filed #21233 for the remaining test failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21232)
<!-- Reviewable:end -->
@KiChjang KiChjang self-assigned this Aug 7, 2018
@KiChjang KiChjang mentioned this issue Aug 18, 2018
Closed
bors-servo pushed a commit that referenced this issue Aug 31, 2018
Auto merge of #21456 - KiChjang:mutation-observer-test-fix, r=<try>
29e4c4b 
[WIP] Mutation observer test fix

Fixes #21233.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21456)
<!-- Reviewable:end -->
@pshaughn
Copy link
Member

pshaughn commented Dec 5, 2019

Has anything further happened with this?

@jdm
Copy link
Member Author

jdm commented Dec 5, 2019

#21456 was an attempt, but it stalled a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KiChjang KiChjang

Labels
A-content/dom Interacting with the DOM from web content
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Mutation observer test fix KiChjang/servo
3 participants
@jdm @pshaughn @KiChjang