Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display-managers: rely on socket to activate pulseaudio #44876

Merged
merged 1 commit into from Aug 12, 2018
Merged

display-managers: rely on socket to activate pulseaudio #44876

merged 1 commit into from Aug 12, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 10, 2018

Motivation for this change

So I can use audio like I normally do. See #44854.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Aug 12, 2018

Thanks, just tested, no more permission errors. :)

@srhb srhb force-pushed the display-managers/pulseaudio-rely-on-socket branch from ced374c to bf08cf3 Compare August 12, 2018 19:50
@eadwu eadwu force-pushed the display-managers/pulseaudio-rely-on-socket branch from bf08cf3 to ced374c Compare August 12, 2018 20:03
@srhb srhb merged commit b4d15af into NixOS:master Aug 12, 2018
@eadwu eadwu deleted the display-managers/pulseaudio-rely-on-socket branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @srhb @GrahamcOfBorg