Skip to content

Commit adbc4d6

Browse files
author
George Leslie-Waksman
committedAug 10, 2018
Review feedback
1 parent 6a93712 commit adbc4d6

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed
 

‎CHANGES.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Features
1515
time is specified, the posting time will be displayed alone.
1616
* All built-in themes now support the ``DATE_FANCINESS`` option.
1717
* Theme bundles are now parsed using the configparser module and
18-
can support newlines inside entries as well ad comments
18+
can support newlines inside entries as well as comments
1919

2020
Bugfixes
2121
--------

‎docs/creating-a-theme.rst

+9-3
Original file line numberDiff line numberDiff line change
@@ -813,8 +813,12 @@ Doing the same for layout-reverse, sidebar-overlay and the rest is left as an ex
813813
Bundles
814814
-------
815815

816-
If you have ``webassets`` installed and the ``USE_BUNDLES`` option set to True, Nikola can put several CSS or JS files together in a larger file,
817-
which makes sites load faster. To do that, your theme needs a ``bundles`` file where the syntax is::
816+
If you have ``webassets`` installed and the ``USE_BUNDLES`` option set to True,
817+
Nikola can put several CSS or JS files together in a larger file, which can
818+
makes site load faster for some deployments. To do this, your theme needs
819+
a ``bundles`` file. The file format is a modified
820+
`config <https://docs.python.org/3/library/configparser.html>`_ file with no
821+
defined section; the basic syntax is::
818822

819823
outputfile1.js=
820824
thing1.js,
@@ -833,7 +837,9 @@ For the Lanyon theme, it should look like this::
833837
code.css,
834838
poole.css,
835839
lanyon.css,
836-
custom.css
840+
custom.css,
841+
842+
**Note:** trailing commas are optional
837843

838844
**Note:** Some themes also support the ``USE_CDN`` option meaning that in some cases it will load one bundle with all CSS and in other will load some CSS files
839845
from a CDN and others from a bundle. This is complicated and probably not worth the effort.

‎docs/theming.rst

+4-3
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,9 @@ parent, engine
7373
older).
7474

7575
bundles
76-
A config file containing a list of files to be turned into bundles using WebAssets.
77-
For example:
76+
A `config <https://docs.python.org/3/library/configparser.html>`_ file
77+
containing a list of files to be turned into bundles using WebAssets. For
78+
example:
7879

7980
.. code:: ini
8081
@@ -85,7 +86,7 @@ bundles
8586
code.css,
8687
baguetteBox.min.css,
8788
theme.css,
88-
custom.css
89+
custom.css,
8990
9091
This creates a file called "assets/css/all.css" in your output that is the
9192
combination of all the other file paths, relative to the output file.

‎nikola/data/symlinked.txt

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ nikola/data/themes/base/assets/js/html5shiv-printshiv.min.js
2323
nikola/data/themes/base/assets/js/justified-layout.min.js
2424
nikola/data/themes/base/assets/js/moment-with-locales.min.js
2525
nikola/data/themes/base/messages/messages_cz.py
26-
nikola/data/themes/base-jinja/bundles
2726
nikola/data/themes/bootblog4-jinja/assets/css/bootblog.css
2827
nikola/data/themes/bootblog4-jinja/bundles
2928
nikola/data/themes/bootstrap4-jinja/assets/css/bootstrap.min.css

‎nikola/data/themes/base-jinja/bundles

-1
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.