Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alarm-clock-applet: fix build #44872

Merged
merged 1 commit into from Aug 10, 2018
Merged

alarm-clock-applet: fix build #44872

merged 1 commit into from Aug 10, 2018

Conversation

rasendubi
Copy link
Member

Motivation for this change

The build has been failing because sourceforge-served release include
-Werror=format=2 flag, which enabled -Werror=format-y2k, which in turn
stopped the build because of a debug log message formatting.

Building release from GitHub works fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@rasendubi
alarm-clock-applet: fix build
d6ddb9b 
The build has been failing because sourceforge-served release include
-Werror=format=2 flag, which enabled -Werror=format-y2k, which in turn
stopped the build because of a debug log message formatting.

Building release from GitHub works fine.
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: alarm-clock-applet

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alarm-clock-applet

Partial log (click to expand)

glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/7vma1wh07c38ywsi005zl6s7j0l0ngfd-alarm-clock-applet-0.3.4/bin/alarm-clock-applet
shrinking RPATHs of ELF executables and libraries in /nix/store/7vma1wh07c38ywsi005zl6s7j0l0ngfd-alarm-clock-applet-0.3.4
shrinking /nix/store/7vma1wh07c38ywsi005zl6s7j0l0ngfd-alarm-clock-applet-0.3.4/bin/.alarm-clock-applet-wrapped
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7vma1wh07c38ywsi005zl6s7j0l0ngfd-alarm-clock-applet-0.3.4/bin 
patching script interpreter paths in /nix/store/7vma1wh07c38ywsi005zl6s7j0l0ngfd-alarm-clock-applet-0.3.4
checking for references to /tmp/nix-build-alarm-clock-applet-0.3.4.drv-0 in /nix/store/7vma1wh07c38ywsi005zl6s7j0l0ngfd-alarm-clock-applet-0.3.4...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: alarm-clock-applet

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4/bin/alarm-clock-applet
shrinking RPATHs of ELF executables and libraries in /nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4
shrinking /nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4/bin/.alarm-clock-applet-wrapped
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4/bin
patching script interpreter paths in /nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4
checking for references to /build in /nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4...
/nix/store/vyw9i61kp75fzxj77i35p1si3m6f7k3a-alarm-clock-applet-0.3.4

@xeji xeji merged commit 6b1a04d into NixOS:master Aug 10, 2018
@rasendubi rasendubi mentioned this pull request Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasendubi @GrahamcOfBorg @xeji