emby: 3.4.1.0 -> 3.5.2.0 #44884
emby: 3.4.1.0 -> 3.5.2.0 #44884
Conversation
This version requires Mono 5.4 or higher, so let's just use the default (5.8 at the moment).
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/MediaBrowser/Emby/releases/download/${version}/Emby.Mono.zip"; | ||
| sha256 = "08jr6v8xhmiwbby0lfvpjrlma280inwh5qp6v4p93lzd07fjynh5"; | ||
| url = "https://github.com/MediaBrowser/Emby.Releases/releases/download/${version}/embyserver-mono_${version}.zip"; |
There was a problem hiding this comment.
Could you switch this to fetchFromGitHub?
There was a problem hiding this comment.
I think fetchFromGitHub only works for git repositories. This is a binary artifact created from the build.
There was a problem hiding this comment.
Then why are we fetching a binary artifact? Can we not build directly from source?
There was a problem hiding this comment.
I don't think emby is publishing their build process.
There was a problem hiding this comment.
I think that is pretty user-hostile. But since we can't fix that and there is currently no way to mark a package as binary, please
- set
preferLocalBuild = trueto tell nix not to build this on hydra (as there is no building involved) - add a comment explaining why we're fetching the binary release with the link you gave here
There was a problem hiding this comment.
Does any of this look helpful?
https://github.com/MediaBrowser/Emby.Build/tree/master/builders/emby-server/debfiles
There was a problem hiding this comment.
Maybe this is it though I think this will be blocked by us not having msbuild.
| @@ -30,7 +30,7 @@ stdenv.mkDerivation rec { | |||
| mkdir -p $out/bin | |||
There was a problem hiding this comment.
It would be nice to quote these: mkdir -p "$out/bin". In theory there might be spaces in a custom nix store path and in general quoting variables is just always safer.
There was a problem hiding this comment.
I agree with you, but I think this is completely unrelated to the package update.
The package might need to be reworked anywaqy in the future to switch from Mono to .NET Core.
There was a problem hiding this comment.
Yes, but I think we should apply the boy scout rule. Otherwise these small improvements will never be made.
|
I get an exception when upgrading from Emby 3.4:
|
This version requires Mono 5.4 or higher, so let's just use
the default (5.8 at the moment).
Motivation for this change
Update to latest version.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @fadenb