Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pyls-black: init at 0.2.1 #44869

Merged
merged 3 commits into from Aug 10, 2018
Merged

python.pkgs.pyls-black: init at 0.2.1 #44869

merged 3 commits into from Aug 10, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 10, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner August 10, 2018 12:17
@Mic92
Copy link
Member Author

Mic92 commented Aug 10, 2018

@GrahamcOfBorg build python3.pkgs.pyls-black

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.pyls-black

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 11 items

tests/test_plugin.py ...........                                         [100%]

========================== 11 passed in 0.98 seconds ===========================
/nix/store/nzil4isrqgwyacqmrna351j08wbzd81q-python3.6-pyls-black-0.2.1

Mic92
Mic92 commented Aug 10, 2018
View reviewed changes
pkgs/development/python-modules/pyls-black/default.nix

src = fetchFromGitHub {
owner = "rupert";
repo = "pyls-black";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github because of https://github.com/rupert/pyls-black/blob/master/setup.py#L15

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.pyls-black

Partial log (click to expand)

running install tests
============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 11 items

tests/test_plugin.py ...........                                         [100%]

========================== 11 passed in 2.57 seconds ===========================
/nix/store/gjfawshsmwnby2m7gkqyc5n7yq5czgr4-python3.6-pyls-black-0.2.1

@Mic92
Copy link
Member Author

Mic92 commented Aug 10, 2018

@GrahamcOfBorg build python3.pkgs.pyls-mypy python3.pkgs.pyls-isort

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.pyls-mypy, python3.pkgs.pyls-isort

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /build/source, inifile:
plugins: cov-2.5.1
collected 4 items

test/test_plugin.py ....                                                 [100%]

========================== 4 passed in 12.04 seconds ===========================
/nix/store/2spyhi87h892aq6c40l64vlmkscssrha-python3.6-pyls-mypy-0.1.3
/nix/store/izga865870aj4sc3nz4i36wq5vlvqyih-python3.6-pyls-isort-0.1.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.pyls-mypy, python3.pkgs.pyls-isort

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /build/source, inifile:
plugins: cov-2.5.1
collected 4 items

test/test_plugin.py ....                                                 [100%]

========================== 4 passed in 10.13 seconds ===========================
/nix/store/mgqkjdkis0dbi5iw7jlh3s1vw9218b36-python3.6-pyls-mypy-0.1.3
/nix/store/943hn4qjvk8pf1yriagif3hlxicxkx0v-python3.6-pyls-isort-0.1.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.pyls-mypy, python3.pkgs.pyls-isort

Partial log (click to expand)

platform darwin -- Python 3.6.6, pytest-3.6.3, py-1.5.4, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python3.6-pyls-mypy-0.1.3.drv-0/source, inifile:
plugins: cov-2.5.1
collected 4 items

test/test_plugin.py ....                                                 [100%]

=========================== 4 passed in 1.79 seconds ===========================
/nix/store/qga0pw4w3wb1d6l8zg1djjfdxr286ksa-python3.6-pyls-mypy-0.1.3
/nix/store/kiz0kxgkfass6mqi5wx38kj8pd5f067c-python3.6-pyls-isort-0.1.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: python3.pkgs.pyls-black

Partial log (click to expand)

clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
building of '/nix/store/r75y9qqf9f32p4cjqjlckaw2c2rhbmwv-python3.6-Cython-0.28.3.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/6sshl95gk4dx70cic2djayx8si4zv45l-python3.6-PyStemmer-1.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bcfjvzslwynz82fxdw896j5cbmlsxs7x-python3.6-snowballstemmer-1.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nv2n000ypdf2206f5ryd4kz7dr4vkd07-python3.6-pydocstyle-2.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6ql0315rccilpxanvhyrylh5mmmwrnd9-python3.6-python-language-server-0.19.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9g7lj9nxf4fpnp6ymqsbb03s3idjkbn5-python3.6-pyls-black-0.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/9g7lj9nxf4fpnp6ymqsbb03s3idjkbn5-python3.6-pyls-black-0.2.1.drv' failed

@Mic92 Mic92 merged commit e140489 into NixOS:master Aug 10, 2018
@Mic92 Mic92 deleted the pyls-black branch September 6, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg