While you're at it, would you mind quoting the variable in patchShebangs $i? Also just in case you know what the purpose of the patch is, it would be nice to document that.

@timokau I'm sorry, but my time was only enough to update the version 😑
crawl_purify.patch changes SQLITE_INCLUDE_DIR in /crawl-ref/source/Makefile
It also changes /crawl-ref/source/util/find_font script (FONTDIRS value, find now has an -L flag)

Well I would appreciate if you make the change once you find the time :)

Now that I think about it that for loop should be unnecessary anyways, patchShebangs 'util' should work just as well. Please also add an explanation comment to the patch ("Patch hard-coded paths in the makefile"). If you want to go the extra mile, it would be best to contact upstream and ask them about configurability. But that's not a hard requirement for me to merge this.

I've made some changes (including changes to all-packages.nix).

Now I'm much more interested in roguelikes such as IVAN or NetHack. So I wouldn't want to spend a lot of time on crawl. However, this time (0.22.0) the crawl-tiles interface looks great 😃

The serious problem is that the file init.txt, which defines the crawl configuration (including language), is loading from the nix store. Crawl shows the path to the used init.txt immediately after loading on the main screen of the app.Thus, it is not possible to play with a configuration other than the default 😞 But I'm not ready to take on this problem 😉

I've made some changes (including changes to all-packages.nix).

Thanks :)

The serious problem is that the file init.txt, which defines the crawl configuration (including language), is loading from the nix store. Thus, it is not possible to play with a configuration other than the default configuration 😢

That sounds like it really should be a user-configuration and not part of the package. It would be best to fix that. But if its not a regression and you don't want to spend the time, I'm happy with the PR as-is.

I'm not sure why you made the all-packages.nix change, but I don't have much of an opinion about that either way. The old way had the advantage/disadvantage that an override to crawl would automatically propagate to crawl-tiles.

init.txt

By the way, stuff like code, filenames etc. is usually enclosed in backticks in markdown, like this: `init.txt` (init.txt). You can also enclose larger code segments in three backticks:

multi
line

@GrahamcOfBorg build crawl crawl-tiles

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: crawl, crawl-tiles

in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `crawl-tiles' because:
error: attribute 'crawl-tiles' in selection path 'crawl-tiles' not found

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: crawl, crawl-tiles

in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `crawl-tiles' because:
error: attribute 'crawl-tiles' in selection path 'crawl-tiles' not found

Success on aarch64-linux (full log)

Attempted: crawl

The following builds were skipped because they don't evaluate on aarch64-linux: crawl-tiles

chown 2>/dev/null  /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0/bin/crawl || true
chmod 2>/dev/null  /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0/bin/crawl || true
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0
shrinking /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0/bin/crawl
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0/bin
patching script interpreter paths in /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0
checking for references to /build in /nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0...
/nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0

Success on aarch64-linux (full log)

Attempted: crawl

The following builds were skipped because they don't evaluate on aarch64-linux: crawl-tiles

Cannot nix-instantiate `crawl-tiles' because:
error: attribute 'crawl-tiles' in selection path 'crawl-tiles' not found

these derivations will be built:
  /nix/store/0w11xajz1mi7nmiwb31ahi8y4hjfhrwg-crawl-0.22.0.drv
waiting for locks or build slots...
/nix/store/dfhzcnc28wqhgxlssryyna007x1irmm9-crawl-0.22.0

Success on x86_64-linux (full log)

Attempted: crawl

The following builds were skipped because they don't evaluate on x86_64-linux: crawl-tiles

chown 2>/dev/null  /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin/crawl || true
chmod 2>/dev/null  /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin/crawl || true
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0
shrinking /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin/crawl
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin
patching script interpreter paths in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0
checking for references to /build in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0...
/nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0

Thanks! :)

I'm not sure why you made the all-packages.nix change, but I don't have much of an opinion about that either way. The old way had the advantage/disadvantage that an override to crawl would automatically propagate to crawl-tiles.

We had some discussion on this topic: #42766 (outdated branch).
Although I personally have no preference on how it will be better.

By the way, stuff like code, filenames etc. is usually enclosed in backticks in markdown, like this: init.txt (init.txt). You can also enclose larger code segments in three backticks:

Thanks! I'll keep that in mind. I'm just a little bit lazy for quality markup 😈

That sounds like it really should be a user-configuration and not part of the package. It would be best to fix that. But if its not a regression and you don't want to spend the time, I'm happy with the PR as-is.

I'm afraid I'm not ready to do that (at least for now) 😑 I will be pleased if you would accept PR as is 😎

We had some discussion on this topic: #42766 (outdated branch).

I think you misunderstood matthewbauer there: He was saying that nethack-x11 shouldn't be in all-packages at all. Users should instead override it themselves if they need it. But apparently he didn't care enough to further argue and I don't really know if I agree.

Anyways, thanks for your contribution.

Success on x86_64-linux (full log)

Attempted: crawl

The following builds were skipped because they don't evaluate on x86_64-linux: crawl-tiles

chown 2>/dev/null  /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin/crawl || true
chmod 2>/dev/null  /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin/crawl || true
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0
shrinking /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin/crawl
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0/bin
patching script interpreter paths in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0
checking for references to /build in /nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0...
/nix/store/d7j3h5kfj5p7nzd0bfs4ddrszf2cl9w2-crawl-0.22.0

Maybe I did misunderstand him 😞 Fortunately, all this can be easily fixed at any time.

Thanks for merging the pull requests and for your patience! 😎