gdbm: avoid a warning on Darwin #44875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build gdbm |
|
Success on x86_64-linux (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: gdbm Partial log (click to expand)
|
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "gdbm-1.17"; | |||
| # FIXME: remove on update to > 1.17 | |||
| NIX_CFLAGS_COMPILE = if stdenv.isDarwin then "-Wno-error=return-type" else null; | |||
There was a problem hiding this comment.
This is nitpicking but technically this should be stdenv.cc.isClang. This works too but just because no one else is using clang.
There was a problem hiding this comment.
Oh, right, I was thinking of build vs. host and didn't realize that the compiler vendor is more likely to be the significant difference.
This is just to minimize rebuilds. The actual bugfix doesn't seem to hurry, as the function has been returning void until now, so if the int returned isn't a meaningful value in some cases, nothing should happen yet.
|
Success on x86_64-darwin (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gdbm Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gdbm Partial log (click to expand)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to minimize rebuilds. The actual bugfix doesn't seem to
hurry, as the function has been returning void until now, so if the int
returned isn't a meaningful value in some cases, nothing should happen
yet.
No rebuild except on Darwin (where it was failing).
I wasn't sure when this is required on cross-compilation, so the condition might be imprecise.