Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.jake init, nodePackages.madoko init #44879

Merged
merged 3 commits into from Aug 16, 2018
Merged

nodePackages.jake init, nodePackages.madoko init #44879

merged 3 commits into from Aug 16, 2018

Conversation

jasoncarr0
Copy link
Contributor

Motivation for this change

Adding two packages to nodePackages.

Jake is a javascript build tool, based on/named after rake, make, etc.
Madoko is a simple markdown -> html processor.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) No relevant tests
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" No dependents
  • Tested execution of all binary files (usually in ./result/bin/)
    Successfully built with jake / produced page with madoko
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    Too difficult to compare all of nodePackages (several broken packages, conflicts when combining). Sizes of just these packages, assuming no new dependencies are 1.1M for jake, 4.9M for madoko
  • Fits CONTRIBUTING.md.

@jasoncarr0 jasoncarr0 changed the title nodePackages.jake init at nodePackages.jake init, nodePackages.madoko init Aug 10, 2018
@matthewbauer
Copy link
Member

@GrahamcOfBorg build nodePackages.jake nodePackages.madoko

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodePackages.jake, nodePackages.madoko

Partial log (click to expand)

chalk@0.4.0 /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18/lib/node_modules/jake/node_modules/chalk
has-color@0.1.7 /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18/lib/node_modules/jake/node_modules/has-color
ansi-styles@1.0.0 /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18/lib/node_modules/jake/node_modules/ansi-styles
strip-ansi@0.1.1 /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18/lib/node_modules/jake/node_modules/strip-ansi
utilities@1.0.5 /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18/lib/node_modules/jake/node_modules/utilities
async@0.9.2 /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18/lib/node_modules/jake/node_modules/async
post-installation fixup
patching script interpreter paths in /nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18
/nix/store/0wkc887c99hq3ddv059zyl89k3hz6l2f-node-jake-8.0.18
/nix/store/lhhap03srsjnkfcq096ykq3rrgdp812y-node-madoko-1.1.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages.jake, nodePackages.madoko

Partial log (click to expand)

patching script interpreter paths in /nix/store/q6sgmfq3mafc8gcfl1b4hbl0h181cyfr-node-madoko-1.1.4
/nix/store/q6sgmfq3mafc8gcfl1b4hbl0h181cyfr-node-madoko-1.1.4/lib/node_modules/madoko/node_modules/requirejs/bin/r.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/fn158mclqsa936hiyknrip0f881vbpvh-nodejs-6.14.3/bin/node"
/nix/store/q6sgmfq3mafc8gcfl1b4hbl0h181cyfr-node-madoko-1.1.4/lib/node_modules/madoko/lib/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/fn158mclqsa936hiyknrip0f881vbpvh-nodejs-6.14.3/bin/node"
checking for references to /build in /nix/store/q6sgmfq3mafc8gcfl1b4hbl0h181cyfr-node-madoko-1.1.4...
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a8jyxa7xnhwydkbr5pa4z6i36sb5h7k2-node-jake-8.0.18
patching script interpreter paths in /nix/store/a8jyxa7xnhwydkbr5pa4z6i36sb5h7k2-node-jake-8.0.18
checking for references to /build in /nix/store/a8jyxa7xnhwydkbr5pa4z6i36sb5h7k2-node-jake-8.0.18...
/nix/store/a8jyxa7xnhwydkbr5pa4z6i36sb5h7k2-node-jake-8.0.18
/nix/store/q6sgmfq3mafc8gcfl1b4hbl0h181cyfr-node-madoko-1.1.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.jake, nodePackages.madoko

Partial log (click to expand)

ansi-styles@1.0.0 /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18/lib/node_modules/jake/node_modules/ansi-styles
strip-ansi@0.1.1 /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18/lib/node_modules/jake/node_modules/strip-ansi
utilities@1.0.5 /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18/lib/node_modules/jake/node_modules/utilities
async@0.9.2 /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18/lib/node_modules/jake/node_modules/async
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18
patching script interpreter paths in /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18
checking for references to /build in /nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18...
/nix/store/snknw0aqlsqmjjd799dspbr55x4z8jg4-node-jake-8.0.18
/nix/store/fl4570iaq587p7mwnhng312wbaa8ac4w-node-madoko-1.1.4

@matthewbauer matthewbauer merged commit bbb0e53 into NixOS:master Aug 16, 2018
@dotlambda dotlambda mentioned this pull request Aug 20, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasoncarr0 @matthewbauer @GrahamcOfBorg @Janik-Haag