-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages.jake init, nodePackages.madoko init #44879
Merged
Merged
+1,079
−1,817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncarr0
changed the title
nodePackages.jake init at
nodePackages.jake init, nodePackages.madoko init
Aug 10, 2018
@GrahamcOfBorg build nodePackages.jake nodePackages.madoko |
Success on x86_64-darwin (full log) Attempted: nodePackages.jake, nodePackages.madoko Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: nodePackages.jake, nodePackages.madoko Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: nodePackages.jake, nodePackages.madoko Partial log (click to expand)
|
Janik-Haag
added
the
12. first-time contribution
This PR is the author's first one; please be gentle!
label
Jun 12, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
12. first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding two packages to nodePackages.
Jake is a javascript build tool, based on/named after rake, make, etc.
Madoko is a simple markdown -> html processor.
Things done
sandbox
innix.conf
on non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)No relevant testsTested compilation of all pkgs that depend on this change usingNo dependentsnix-shell -p nox --run "nox-review wip"
./result/bin/
)Successfully built with jake / produced page with madoko
nix path-info -S
before and after)Too difficult to compare all of nodePackages (several broken packages, conflicts when combining). Sizes of just these packages, assuming no new dependencies are 1.1M for jake, 4.9M for madoko