Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken packges that do not build #44378

Closed
wants to merge 1 commit into from
Closed

Fix broken packges that do not build #44378

wants to merge 1 commit into from

Conversation

ngortheone
Copy link
Contributor

Cherry-picking fixes from master

Motivation for this change

Currently these packages do not build in 18.03 do to unreachable
patches and they are fixed in master.

Fix broken packges that do not build
fd4611d 
Cherr-pick from master
Currently these packages do not build in 18.03 do to unreachable
patches and they are fixed in master.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ labels Aug 2, 2018
@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

Please split your changes into separate commits (in most cases one commit per package), for easier review and cleaner history. If possible try to git cherry-pick -x the corresponding changes from master so we can track each change to its origin.

@ngortheone ngortheone closed this Aug 2, 2018
@ngortheone
Copy link
Contributor Author

@xeji the problem is that it is quite tedious to track all commits that affected these packages. For example there were commits that touched all packages (like 52f53c6)

Cherry-picking that will not make tracking changes easier. I can definitely split this into 3 different PRs, but I am not sure whether it will be possible to do git cherry-pick -x for them

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

No problem. git cherry-pick -x is our preferred method for backporting changes but it doesn't always work well. Just give it a try first before you do something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngortheone @xeji @GrahamcOfBorg