Chart data files #3130
Merged
Chart data files #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
reviewed
Aug 2, 2018
docs/manual.rst
Outdated
| 'Firefox', [None, None, 0, 16.6, 25, 31] | ||
| 'Chrome', [None, None, None, None, None, None] | ||
| 'IE', [85.8, 84.6, 84.7, 74.5, 66, 58.6] | ||
| 'Others', [14.2, 15.4, 15.3, 8.9, 9, 10.4] | ||
| {{% /chart %}}{{% /raw %}} | ||
| {{% /chart %}} |
There was a problem hiding this comment.
they need to be on the same line
| {{% raw %}}{{% chart Bar title='Browser usage evolution (in %)' %}} | ||
| x_labels='["2002","2003","2004","2005","2006","2007","2008","2009","2010","2011","2012"]'%}} | ||
| {{% raw %}}{{% chart Bar title='Browser usage evolution (in %)' | ||
| x_labels='["2002","2003","2004","2005","2006","2007"]' %}} |
There was a problem hiding this comment.
Is this a syntax change or a fix to the docs?
There was a problem hiding this comment.
Just a fix for the docs, things were different lengths
There was a problem hiding this comment.
You moved x_labels from “inside” the shortcode to its arguments.
There was a problem hiding this comment.
Hmmm that was broken, I think.
nikola/plugins/shortcode/chart.py
Outdated
| try: | ||
| options[k] = literal_eval(v) | ||
| for k, v in options.items(): | ||
| try: options[k] = literal_eval(v) |
Kwpolska
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a data_file option to chart shortcode and directive as sort-of-per #3129