flatpak: Don't hardcode flatpak binary path in launchers #44366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardcoded flatpak path breaks all installed applications when flatpak is updated. fixes: NixOS#43581
jtojnar
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The hardcoded flatpak path broke all installed applications when flatpak is
updated.
fixes: #43581
Some tests that were expecting
Exec=.*/flatpakin the .desktop files needed patching.cc @jtojnar @xeji
Things done
I've run the
nixos.tests.flatpaktest and I'm not getting any failures, but the return code isn't0for some reason. Not sure if that's a regression or not (the tests takes forever).sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)