Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefoxWrapper: Fail if deprecated enableVLC option exists #44934

Merged
merged 1 commit into from Aug 13, 2018
Merged

firefoxWrapper: Fail if deprecated enableVLC option exists #44934

merged 1 commit into from Aug 13, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 12, 2018 •
edited

Motivation for this change

Don't silently fail if user has deprecated option enableVLC
#44931

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from vcunat August 12, 2018 11:39
@infinisil
Copy link
Member

Why was it removed? Might be worth noting that in the throw.

@vcunat
Copy link
Member

vcunat commented Aug 12, 2018

The whole plugins = ... can be cleaned except for flash, removing some packages completely, too. I have a WIP on that, planning to submit it a few days later, after this PR (it will conflict anyway).

@infinisil infinisil merged commit 46516d8 into NixOS:master Aug 13, 2018
@xaverdh
Copy link
Contributor

xaverdh commented Apr 14, 2020 •
edited

The whole plugins = ... can be cleaned except for flash, removing some packages completely, too. I have a WIP on that, planning to submit it a few days later, after this PR (it will conflict anyway).

According to #84909 it looks like the plugins stuff is still present?

@xaverdh
Copy link
Contributor

xaverdh commented Apr 15, 2020

Opened #85307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srhb @infinisil @vcunat @xaverdh @GrahamcOfBorg