Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: fix tzdata path #44913

Merged
merged 1 commit into from Aug 14, 2018
Merged

postgresql: fix tzdata path #44913

merged 1 commit into from Aug 14, 2018

Conversation

hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Aug 11, 2018

Motivation for this change

The timezone path is set incorrectly. Since e8682ca tzdata is used by default which broke my PostgreSQL installations.

PostgreSQL does use the full path to the timezone files as zone name. Thus the following does currently not work:

SELECT now() AT TIME ZONE 'Europe/Vienna';

While this does:

SELECT now() AT TIME ZONE 'share/zoneinfo/Europe/Vienna';

Timezone names can also be checked with:

SELECT * from pg_timezone_names;

This patch corrects the path set during configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ocharles, @dingxiangfei2009

@hrdinka
postgresql: fix tzdata path
df6416a 
Signed-off-by: Christoph Hrdinka <c.github@hrdinka.at>
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

checking for references to /build in /nix/store/3l56d7xzjrss8ydwmw8bpb0g3wsi9b0v-postgresql-9.6.9-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/bjkqiax7010r70vj79v3a6rlizrzz8wy-postgresql-9.6.9-doc
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/bjkqiax7010r70vj79v3a6rlizrzz8wy-postgresql-9.6.9-doc
checking for references to /build in /nix/store/bjkqiax7010r70vj79v3a6rlizrzz8wy-postgresql-9.6.9-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/m0npq3ggw7a5q6caci9s8p2c1s8m6hpb-postgresql-9.6.9-man
gzipping man pages under /nix/store/m0npq3ggw7a5q6caci9s8p2c1s8m6hpb-postgresql-9.6.9-man/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/m0npq3ggw7a5q6caci9s8p2c1s8m6hpb-postgresql-9.6.9-man
checking for references to /build in /nix/store/m0npq3ggw7a5q6caci9s8p2c1s8m6hpb-postgresql-9.6.9-man...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/sjjhw7kgh4h7k56lp17h9cjy7hyklpkk-postgresql-9.6.9-doc
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sjjhw7kgh4h7k56lp17h9cjy7hyklpkk-postgresql-9.6.9-doc
checking for references to /build in /nix/store/sjjhw7kgh4h7k56lp17h9cjy7hyklpkk-postgresql-9.6.9-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/yjk94r1546acg6gsvzib26vdljrrvdqw-postgresql-9.6.9-man
gzipping man pages under /nix/store/yjk94r1546acg6gsvzib26vdljrrvdqw-postgresql-9.6.9-man/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/yjk94r1546acg6gsvzib26vdljrrvdqw-postgresql-9.6.9-man
checking for references to /build in /nix/store/yjk94r1546acg6gsvzib26vdljrrvdqw-postgresql-9.6.9-man...
/nix/store/bz691d0m8q8g72fvf1fyg0s8cr1d20dg-postgresql-9.6.9

@thefloweringash thefloweringash mentioned this pull request Aug 13, 2018
Closed
9 tasks
@hrdinka hrdinka requested a review from ocharles August 14, 2018 17:27
@ocharles
Copy link
Contributor

This looks good to me. Thanks!

@ocharles ocharles merged commit 72a3553 into NixOS:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
0.kind: bug 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hrdinka @GrahamcOfBorg @ocharles