Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iwd: 0.4 -> 0.7 #44890

Merged
merged 1 commit into from Aug 26, 2018
Merged

iwd: 0.4 -> 0.7 #44890

merged 1 commit into from Aug 26, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Aug 11, 2018

https://git.kernel.org/pub/scm/network/wireless/iwd.git/tree/ChangeLog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @Mic92

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iwd

Partial log (click to expand)

wrapping `/nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6/bin/connect-network'...
shrinking RPATHs of ELF executables and libraries in /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6
shrinking /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6/libexec/iwd
shrinking /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6/bin/iwmon
shrinking /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6/bin/iwctl
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6/libexec  /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6/bin
patching script interpreter paths in /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6
checking for references to /build in /nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6...
/nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iwd

Partial log (click to expand)

wrapping `/nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6/bin/set-mode'...
shrinking RPATHs of ELF executables and libraries in /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6
shrinking /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6/libexec/iwd
shrinking /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6/bin/iwctl
shrinking /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6/bin/iwmon
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6/libexec  /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6/bin
patching script interpreter paths in /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6
checking for references to /build in /nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6...
/nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6

@Mic92
Copy link
Member

Mic92 commented Aug 11, 2018

Does it make sense to also enable dbus socket activation?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iwd

Partial log (click to expand)

/nix/store/9kwxgw0r88whii5x8szfvgbw7f6zx3g5-iwd-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iwd

Partial log (click to expand)

/nix/store/q0inpsw5nadf69j2hvxgq716vqb5sy18-iwd-0.6

Mic92
Mic92 reviewed Aug 13, 2018
View reviewed changes
nixos/modules/services/networking/iwd.nix Outdated
};
};

systemd.services."net-connman-iwd" = {
Copy link
Member

@Mic92 Mic92 Aug 13, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dbus service file should be rather read from the package and iwd added to services.dbus.packages:
https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/hardware/fwupd.nix#L83

Dbus services are a separate from systemd services and read by the dbus daemon from /etc/dbus-1/session.conf on startup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use iwd.service from the package too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, this is the preferred way.

@dywedir dywedir changed the title iwd: 0.4 -> 0.6 iwd: 0.4 -> 0.7 Aug 25, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iwd

Partial log (click to expand)

wrapping `/nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/bin/wps-cancel'...
shrinking RPATHs of ELF executables and libraries in /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7
shrinking /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/libexec/iwd
shrinking /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/bin/iwmon
shrinking /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/bin/iwctl
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/lib  /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/libexec  /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7/bin
patching script interpreter paths in /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7
checking for references to /build in /nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7...
/nix/store/4sh8mbgpdrp1rksm9fjw1wv0qyf8f63z-iwd-0.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iwd

Partial log (click to expand)

wrapping `/nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/bin/connect-network'...
shrinking RPATHs of ELF executables and libraries in /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7
shrinking /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/libexec/iwd
shrinking /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/bin/iwmon
shrinking /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/bin/iwctl
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/lib  /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/libexec  /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7/bin
patching script interpreter paths in /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7
checking for references to /build in /nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7...
/nix/store/dm9i8f9rbyq2l9g2zv7ngp68mhhf77ps-iwd-0.7

@Mic92 Mic92 merged commit a78b364 into NixOS:master Aug 26, 2018
@dywedir dywedir deleted the iwd branch September 8, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @GrahamcOfBorg @Mic92