Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxnd and libndypes: init at 0.2.0dev3 #44914

Merged
merged 2 commits into from Aug 27, 2018
Merged

libxnd and libndypes: init at 0.2.0dev3 #44914

merged 2 commits into from Aug 27, 2018

Conversation

costrouc
Copy link
Member

Motivation for this change

Wanted to experiment with xnd package in nix so created packaging description.

Things done

libxnd: init at 0.2.0dev3
libndtypes: init at 0.2.0dev3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc
libndtypes: init at 0.2.0dev3
e2f9206 
Dynamic types for data description and in-memory computations
joachifm
joachifm reviewed Aug 19, 2018
View reviewed changes
pkgs/development/libraries/libxnd/default.nix Outdated
makeFlags = [ "CONFIGURE_LDFLAGS='-shared'" ];

meta = {
description = "General container that maps a wide range of Python values directly to memory.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please remove the trailing punctuation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Should be ready for merging now

@joachifm
Copy link
Contributor

@GrahamcOfBorg build libxnd

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: libxnd

Partial log (click to expand)

clang -I.. -Wall -Wextra -std=c11 -pedantic -O2 -g -fPIC -c util.c -o .objs/util.o
clang -I.. -Wall -Wextra -std=c11 -pedantic -O2 -g -fPIC -c values.c -o .objs/values.o
ld '-shared' -o libndtypes.0.2.0dev3.dylib .objs/alloc.o .objs/attr.o .objs/context.o .objs/copy.o .objs/encodings.o .objs/equal.o .objs/grammar.o .objs/io.o .objs/lexer.o .objs/match.o .objs/ndtypes.o .objs/parsefuncs.o .objs/parser.o .objs/seq.o .objs/symtable.o .objs/util.o .objs/values.o compat/.objs/bpgrammar.o compat/.objs/bplexer.o compat/.objs/import.o
ld: unknown option: -shared
make[1]: *** [Makefile:57: libndtypes.0.2.0dev3.dylib] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-libndtypes-0.2.0dev3.drv-0/source/libndtypes'
make: *** [Makefile:23: default] Error 2
builder for '/nix/store/c5jjw9gsdrs3kcskq7lkzpxq2y7c2qhn-libndtypes-0.2.0dev3.drv' failed with exit code 2
cannot build derivation '/nix/store/6jm4cwzx4v91n9iwbm7674mrinxif8mw-libxnd-0.2.0dev3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6jm4cwzx4v91n9iwbm7674mrinxif8mw-libxnd-0.2.0dev3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libxnd

Partial log (click to expand)

/nix/store/llyw6zn8bhwj6zw6lzdlxyd25bk0bwn1-coreutils-8.29/bin/install -c -d -m 755 /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3/share/doc/xnd
cp -R doc/* /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3/share/doc/xnd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3
shrinking /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3/lib/libxnd.so.0.2.0dev3
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3/lib
patching script interpreter paths in /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3
checking for references to /build in /nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3...
/nix/store/cwiyq6sw0x46bwpjjsc1h1jgn05rqwzq-libxnd-0.2.0dev3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libxnd

Partial log (click to expand)

/nix/store/k1vvnj94k17lcr04k1i8arslf2nd5lzv-coreutils-8.29/bin/install -c -d -m 755 /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3/share/doc/xnd
cp -R doc/* /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3/share/doc/xnd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3
shrinking /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3/lib/libxnd.so.0.2.0dev3
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3/lib
patching script interpreter paths in /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3
checking for references to /build in /nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3...
/nix/store/89i1c8mfxj9z85izwpshmb7xmx5zi3rs-libxnd-0.2.0dev3

@costrouc
libxnd: init at 0.2.0dev3
dd12060 
General container that maps a wide range of Python values directly to memory."
@costrouc
Copy link
Member Author

The reason that it does not build on darwin is due to the weird structure of the cmake script. I had the override the makeFlags that the cmake script generates. Hopefully in the future it will be addressed by the devs. Otherwise it fully works on arm and x86_64.

@costrouc
Copy link
Member Author

It should be ready for merging now.

@joachifm joachifm merged commit c383462 into NixOS:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @joachifm @GrahamcOfBorg