Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efibootmgr: 16 -> 17 #44927

Closed
wants to merge 1 commit into from
Closed

efibootmgr: 16 -> 17 #44927

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Aug 12, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: efibootmgr

Partial log (click to expand)

these paths will be fetched (0.10 MiB download, 0.33 MiB unpacked):
  /nix/store/6gxb7dynzxmf0sk5p1nn9gmzzcw3c1ip-efivar-36
  /nix/store/mkqljlswh65fswis2g7xnfbxh04n2wk2-efibootmgr-17
copying path '/nix/store/6gxb7dynzxmf0sk5p1nn9gmzzcw3c1ip-efivar-36' from 'https://cache.nixos.org'...
copying path '/nix/store/mkqljlswh65fswis2g7xnfbxh04n2wk2-efibootmgr-17' from 'https://cache.nixos.org'...
/nix/store/mkqljlswh65fswis2g7xnfbxh04n2wk2-efibootmgr-17

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: efibootmgr

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17
shrinking /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17/sbin/efibootdump
shrinking /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17/sbin/efibootmgr
gzipping man pages under /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17/sbin
patching script interpreter paths in /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17
checking for references to /build in /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17...
moving /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17/sbin/* to /nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17/bin
/nix/store/c9jq2nbwkiqkhmnx01qn9vgb4qkcgh27-efibootmgr-17

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: efibootmgr

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@srhb
Copy link
Contributor Author

srhb commented Aug 12, 2018

Tested in a UEFI virtual machine with a grub2 installation, since I believe that's the only installation that uses efibootmgr (which is not covered by our tests, as far as I can see.)

It correctly installs a boot entry NixOS-boot which boots correctly.

@xeji
Copy link
Contributor

xeji commented Aug 13, 2018

closing as duplicate of #44786 , which was merged a few days ago.

@xeji xeji closed this Aug 13, 2018
@srhb srhb deleted the bump-efibootmgr branch August 13, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @xeji