Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectx: init at v0.5.1 #44929

Merged
merged 1 commit into from Aug 12, 2018
Merged

kubectx: init at v0.5.1 #44929

merged 1 commit into from Aug 12, 2018

Conversation

periklis
Copy link
Contributor

Motivation for this change

Provides two simple bash utilities to make switching between different kubernetes clusters (e.g. dev, prod, minikube) as well as namespaces inside a cluster an easy task.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb self-assigned this Aug 12, 2018
@srhb
Copy link
Contributor

srhb commented Aug 12, 2018

I think it would make sense to depend on kubectl and patch in its path properly into the scripts. Right now it's possible to install kubectx and get kubectx: line 44: kubectl: command not found

We can easily fix this and make it a nicer user experience. :)

@periklis
Copy link
Contributor Author

👍 I almost forgot about this :)

@periklis
Copy link
Contributor Author

@srhb Thx again for the notice. Something like this happens when one doesn't package so often. Now both utilities have kubectl in their path thanks to wrapProgram.

@srhb
Copy link
Contributor

srhb commented Aug 12, 2018

Tiny nit: The other kube utilities (kubectl, kubetail ...) appear to live mostly in applications/networking/cluster (and in that section in all-packages.nix as well) -- do you mind making that change?

@srhb
Copy link
Contributor

srhb commented Aug 12, 2018

Well, hm, nevermind, I can see that it's a bit mixed already. Merging once green.

@srhb srhb merged commit 1d7c7cc into NixOS:master Aug 12, 2018
@srhb
Copy link
Contributor

srhb commented Aug 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srhb srhb

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @srhb @GrahamcOfBorg